Skip to content

Copy favicon.ico to website root during build#5637

Merged
madskristensen merged 1 commit into
masterfrom
copilot/add-favicon-to-deploy
Apr 29, 2026
Merged

Copy favicon.ico to website root during build#5637
madskristensen merged 1 commit into
masterfrom
copilot/add-favicon-to-deploy

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 29, 2026

/favicon.ico was never deployed to the website root, causing 404s on direct requests. The build copied src/img/favicon/ correctly (serving the <link rel="icon"> tags), but browsers and crawlers also probe /favicon.ico at the root level.

Changes

  • cli.jstaskBuildWebsite: Added explicit copyFile to place src/favicon.ico at website/favicon.ico
await fs.copyFile('./src/favicon.ico', './website/favicon.ico')

Agent-Logs-Url: https://github.com/SchemaStore/schemastore/sessions/8d301daf-a8e7-4d64-baa2-dc41c2007c22

Co-authored-by: madskristensen <1258877+madskristensen@users.noreply.github.com>
@madskristensen madskristensen marked this pull request as ready for review April 29, 2026 21:20
@madskristensen madskristensen merged commit a0afa4c into master Apr 29, 2026
3 of 4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants