Skip to content

feat: customizable footer message#411

Merged
emigun merged 1 commit into
developfrom
add-maxiv-footer-links
May 20, 2026
Merged

feat: customizable footer message#411
emigun merged 1 commit into
developfrom
add-maxiv-footer-links

Conversation

@emigun

@emigun emigun commented May 13, 2026

Copy link
Copy Markdown
Member

Description

Customizable footer message with free text and links.

Removed showLogoBanner (as per Max request)

Motivation

We would like to have links to the data policy.

image

@emigun
emigun force-pushed the add-maxiv-footer-links branch 4 times, most recently from ffa6d2f to 0e53056 Compare May 19, 2026 13:55

@nitrosx nitrosx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes!!!

Question: do you think we can remove all the environments' files?
They are confusing and are not needed if we provide examples for the footer.

Comment thread src/assets/config.example.json Outdated
} No newline at end of file
"contactEmail": "support@scicat.eu",
"footerMessage": {
"text": "For more information visit:",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an html string for the footer text?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated so that it is now possible to add HTML content in the footer text.

@emigun
emigun force-pushed the add-maxiv-footer-links branch from 0e53056 to 45d4302 Compare May 20, 2026 07:07
@emigun

emigun commented May 20, 2026

Copy link
Copy Markdown
Member Author

Question: do you think we can remove all the environments' files? They are confusing and are not needed if we provide examples for the footer.

Probably out of scope for this PR?

I think that needs to be checked with other facilities. For example, I see that we are actually using the environment.maxivprod.ts. I should change that...to use a config.json in /assets/ instead.

Perhaps each facility should okay removing their specific environment.{facility}.ts files?

@nitrosx

nitrosx commented May 20, 2026

Copy link
Copy Markdown
Member

Fair enough!!!
Let's save the environment files for a future pr.

@emigun
emigun merged commit c25f471 into develop May 20, 2026
6 checks passed
@emigun
emigun deleted the add-maxiv-footer-links branch May 20, 2026 10:09
@emigun emigun changed the title feat: maxiv footer links feat: customizable footer message May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants