Suppress errors when we make a base model with no data

[thompson318]

In GitLab by @StephenThompson on Jan 16, 2020, 16:24

[thompson318]

In GitLab by @StephenThompson on Jan 16, 2020, 16:29

If we use VTKSurfaceModel to init an empty model we get error messages to the console when we try and transform it. Let's turn them off

[thompson318]

In GitLab by @StephenThompson on Jan 16, 2020, 16:34

mentioned in commit e7d9d93

[thompson318]

In GitLab by @MattClarkson on Jan 22, 2020, 08:46

When is this required?

Also - just to note, there are 2 types of transformation. First method is to set a transform on the actor. Second method is to actually transform the data using a vtkTransformFilter. Im guessing you refer to the latter?

[thompson318]

In GitLab by @StephenThompson on Jan 22, 2020, 08:56

Anytime you init vtkSurfaceModel without a file name. This impacts derived classes such as vtkCylinderModel, which has the call.

super(VTKCylinderModel, self).init(None, colour, visibility, opacity)

However I'm not sure that suppressing the errors is the right way to go about it. I'll try and have another look at it.

[thompson318]

In GitLab by @MattClarkson on Jan 22, 2020, 08:58

Might be time to have base class, then derived classes, one of which loads from files, one of which generates from source?

[thompson318]

In GitLab by @MattClarkson on Jan 22, 2020, 08:58

then further derived classes thereafter?

[thompson318]

In GitLab by @StephenThompson on Jan 22, 2020, 08:59

That sounds more robust.

[thompson318]

In GitLab by @StephenThompson on Jan 30, 2020, 17:59

mentioned in commit e539214

[thompson318]

In GitLab by @StephenThompson on Jan 31, 2020, 09:31

mentioned in commit ebeb8d6

[thompson318]

In GitLab by @StephenThompson on Jan 31, 2020, 09:31

mentioned in commit ee327da

[mxochicale]

Hi @MattClarkson and @thompson318 ,

Shall we close this one? In the meantime, I labelled as low priority.

Thanks

[thompson318]

I'd still like to fix this at some point.