Skip to content

Commit 3b4499b

Browse files
Always use allow_reresolve=false in downgrade workflows; remove the input
The downgrade compat workflows should never re-resolve (and thus relax) the downgraded environment, since that defeats the purpose of testing the oldest declared-compatible versions. Hardcode allow_reresolve: false in both downgrade.yml and sublibrary-downgrade.yml and remove the allow-reresolve workflow_call input so it cannot be overridden. This removes a workflow_call input, which is breaking for any caller that passes allow-reresolve:. Caller-cleanup PRs that drop that line must merge before v1 is retagged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent e14c855 commit 3b4499b

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

.github/workflows/downgrade.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,6 @@ on:
3333
default: "deps"
3434
required: false
3535
type: string
36-
allow-reresolve:
37-
description: "Allow Pkg to re-resolve (and thus relax) the downgraded environment when running tests"
38-
default: false
39-
required: false
40-
type: boolean
4136
self-hosted:
4237
description: "Run the job on a self hosted machine"
4338
default: false
@@ -73,6 +68,6 @@ jobs:
7368
- uses: julia-actions/julia-runtest@v1
7469
with:
7570
project: "${{ inputs.project }}"
76-
allow_reresolve: "${{ inputs.allow-reresolve }}"
71+
allow_reresolve: false
7772
env:
7873
GROUP: "${{ inputs.group }}"

.github/workflows/sublibrary-downgrade.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@ on:
2727
default: ""
2828
required: false
2929
type: string
30-
allow-reresolve:
31-
description: "Allow the test environment to resolve transitive/test-only deps the downgrade step does not lock"
32-
default: true
33-
required: false
34-
type: boolean
3530
group-env-name:
3631
description: "Optional env var name to set as the test group for each sublibrary (e.g. ODEDIFFEQ_TEST_GROUP)"
3732
default: ""
@@ -109,4 +104,4 @@ jobs:
109104
- uses: julia-actions/julia-runtest@v1
110105
with:
111106
project: ${{ matrix.project }}
112-
allow_reresolve: ${{ inputs.allow-reresolve }}
107+
allow_reresolve: false

0 commit comments

Comments
 (0)