Merge pull request #455 from ChrisRackauckas-Claude/fix/type-stability-454

Fix type instability in solve pathway (#454)

Author: ChrisRackauckas

Project.toml

@@ -60,7 +60,7 @@ Random = "1.10"
 ReTestItems = "1.29"
 RecursiveArrayTools = "3.31.2"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 Sparspak = "0.3.11"
 StaticArrays = "1.9.8"
 Test = "1.10"

lib/BoundaryValueDiffEqAscher/Project.toml

@@ -36,7 +36,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.130.0"
+SciMLBase = "2.152.1"
 Setfield = "1.1.1"
 StaticArrays = "1.9.8"
 Test = "1.10"

lib/BoundaryValueDiffEqCore/Project.toml

@@ -47,7 +47,7 @@ OptimizationBase = "3.2.0, 4, 5"
 PreallocationTools = "0.4, 1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 SciMLLogging = "1.8.0"
 SciMLStructures = "1.7.0"
 Setfield = "1"

lib/BoundaryValueDiffEqFIRK/Project.toml

@@ -53,7 +53,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 SciMLStructures = "1.7.0"
 Setfield = "1.1.1"
 SparseArrays = "1.10"

lib/BoundaryValueDiffEqMIRK/Project.toml

@@ -53,7 +53,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 SciMLStructures = "1.7.0"
 Setfield = "1.1.1"
 SparseArrays = "1.10"

lib/BoundaryValueDiffEqMIRKN/Project.toml

@@ -48,7 +48,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.130.0"
+SciMLBase = "2.152.1"
 Setfield = "1.1.1"
 SparseArrays = "1.10"
 StaticArrays = "1.9.8"

lib/BoundaryValueDiffEqShooting/Project.toml

@@ -51,7 +51,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.130.0"
+SciMLBase = "2.152.1"
 Setfield = "1.1.1"
 SparseArrays = "1.10"
 StaticArrays = "1.9.8"

test/misc/type_stability_tests.jl

@@ -1,5 +1,5 @@
 @testitem "Type Stability" begin
-    using LinearAlgebra, BoundaryValueDiffEq, OrdinaryDiffEqTsit5
+    using LinearAlgebra, BoundaryValueDiffEq, OrdinaryDiffEqTsit5, SciMLBase
 
     f(u, p, t) = [p[1] * u[1] - p[2] * u[1] * u[2], p[3] * u[1] * u[2] - p[4] * u[2]]
     function f!(du, u, p, t)
@@ -24,10 +24,22 @@
 
     jac_alg = BVPJacobianAlgorithm(AutoForwardDiff(; chunksize = 2))
 
+    # BVProblem constructor type stability (issue #454)
+    # Explicit {iip} constructors should be type-stable
+    @testset "BVProblem Constructor" begin
+        @inferred BVProblem{true}(f!, bc!, u0, tspan, p)
+        @inferred BVProblem{false}(f, bc, u0, tspan, p)
+
+        # __init should be type-stable with properly typed problems
+        prob_iip = BVProblem{true}(f!, bc!, u0, tspan, p)
+        @inferred SciMLBase.__init(prob_iip, MIRK5(; jac_alg); dt = 0.2)
+    end
+
     # Multi-Point BVP
+    # nlls is properly inferred as false for StandardBVProblem without bcresid_prototype
     @testset "Multi-Point BVP" begin
-        mpbvp_iip = BVProblem(f!, bc!, u0, tspan, p; nlls = Val(false))
-        mpbvp_oop = BVProblem(f, bc, u0, tspan, p; nlls = Val(false))
+        mpbvp_iip = BVProblem(f!, bc!, u0, tspan, p)
+        mpbvp_oop = BVProblem(f, bc, u0, tspan, p)
 
         # Shooting methods have deep type instability from NonlinearSolve/OrdinaryDiffEq
         # that requires further investigation. The solvers work correctly but return type