Fix @static_unpack type parameters and add JET tests#324
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Fix @static_unpack type parameters and add JET tests#324ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
- Fix _maybe_SArray functions in static_arrays.jl to properly construct SVector and SArray types by including element type parameter and using Tuple(x) conversion for type stability - Add JET.jl as test dependency - Add JET type stability tests for core ComponentArray operations - The @static_unpack macro now correctly returns SVector and SMatrix types 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
a588abe to
a88fc9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_maybe_SArrayfunctions instatic_arrays.jl: The original code was trying to constructSVector{N}(x)andSArray{Tuple{Sz...}}(x)without element type parameters and without converting toTuple, which causedMethodErrors. Now properly constructsSVector{N, T}(Tuple(x))andSArray{Tuple{Sz...}, T, N, prod(Sz)}(Tuple(x)).test/jet_tests.jlto test type stability of core ComponentArray operations (getdata, getaxes, getindex).Background
Ran JET.jl analysis on the package which identified several issues. The most actionable one was the
_maybe_SArrayfunctions used by@static_unpackwhich had incorrect type signatures for constructingSVectorandSArraytypes. The macro now correctly returnsSVectorandSMatrixtypes.Before fix:
After fix:
Test plan
Pkg.test())@static_unpackwith vectors and matricescc @ChrisRackauckas
🤖 Generated with Claude Code