Make docs logo into a copy instead of a symlink #366
Merged
ChrisRackauckas merged 1 commit intoSciML:mainfrom May 5, 2026
Merged
Make docs logo into a copy instead of a symlink #366ChrisRackauckas merged 1 commit intoSciML:mainfrom
ChrisRackauckas merged 1 commit intoSciML:mainfrom
Conversation
Comment on lines
+7
to
+9
| # Copy the logo from root assets to doc assets folder so that Documenter can use | ||
| # it as favicon/sidebar logo | ||
| cp("./assets/logo.png", "./docs/src/assets/logo.png", force = true) |
Member
There was a problem hiding this comment.
Why not just put it there?
Contributor
Author
There was a problem hiding this comment.
Just to keep it in sync with the main logo file, should that get updated. I was following from SciML's practice of Project.toml and Manifest.toml files, but if the logo is expected to be static, I can definitely push a commit that just makes the symlink into a copy instead. 👍
abhro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Additional context
Turns out symlinks fail on deploying docs builds, so just copy it over manually every time