Skip to content

Fix downgrade bounds and dataset comparisons#634

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:fix-dataset-floating-comparisons
Jul 9, 2026
Merged

Fix downgrade bounds and dataset comparisons#634
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:fix-dataset-floating-comparisons

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

This PR should be ignored until reviewed by @ChrisRackauckas.

Summary

  • Replace exact floating-point equality checks in DataDrivenDataset tests with approximate comparisons where equivalent symbolic basis evaluations differ by roundoff.
  • Raise stale lower bounds that made downgrade CI produce incompatible resolver graphs for root, DataDrivenSparse, DataDrivenSR, and DataDrivenLux.
  • Add test-only DataStructures bounds for sublibraries whose downgraded test manifests otherwise pin DataStructures too low for SymbolicUtils/MultivariatePolynomials.

Root Cause

The current Symbolics/ModelingToolkit/SciML stack requires newer transitive versions than several sublibrary lower bounds allowed. The downgrade workflow minimized direct test dependencies into combinations that Pkg could not resolve during Pkg.test. The Core test failure was separate: equivalent dataset constructors evaluated through slightly different floating-point paths, so exact equality was too strict.

Validation

  • GROUP=Core timeout 3600 ~/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test()'\n- DataDrivenSparse downgrade action reproduction + Pkg.test(... allow_reresolve=false)\n- DataDrivenSR downgrade action reproduction + Pkg.test(... allow_reresolve=false)\n- DataDrivenLux downgrade action reproduction + Pkg.test(... allow_reresolve=false)\n- timeout 3600 julia --project=.runic-env -m Runic --check src test docs lib\n

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review July 9, 2026 07:07
@ChrisRackauckas ChrisRackauckas merged commit 7bcc304 into SciML:master Jul 9, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants