Fix downgrade bounds and dataset comparisons#634
Merged
ChrisRackauckas merged 1 commit intoJul 9, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
DataDrivenDatasettests with approximate comparisons where equivalent symbolic basis evaluations differ by roundoff.DataStructuresbounds for sublibraries whose downgraded test manifests otherwise pinDataStructurestoo low forSymbolicUtils/MultivariatePolynomials.Root Cause
The current Symbolics/ModelingToolkit/SciML stack requires newer transitive versions than several sublibrary lower bounds allowed. The downgrade workflow minimized direct test dependencies into combinations that Pkg could not resolve during
Pkg.test. The Core test failure was separate: equivalent dataset constructors evaluated through slightly different floating-point paths, so exact equality was too strict.Validation
GROUP=Core timeout 3600 ~/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test()'\n- DataDrivenSparse downgrade action reproduction +Pkg.test(... allow_reresolve=false)\n- DataDrivenSR downgrade action reproduction +Pkg.test(... allow_reresolve=false)\n- DataDrivenLux downgrade action reproduction +Pkg.test(... allow_reresolve=false)\n-timeout 3600 julia --project=.runic-env -m Runic --check src test docs lib\n