Commit 90b22a0
Require FindFirstFunctions 3.2 for AD-valued interpolation knots
Reconstructing an interpolation inside ForwardDiff promotes both the values
and the knot vector to `ForwardDiff.Dual`. On FindFirstFunctions < 3.2 the
`SearchProperties` linearity probe attempted an invalid `Float64(::Dual)`
conversion, breaking `LinearInterpolation` (and the other constructors) for
11+ knots — the v9.0.0 regression.
FindFirstFunctions 3.2 fixes the probe upstream (SciML/FindFirstFunctions.jl#100),
so no local opt-out shim is needed: bump the compat lower bound to `3.2` and
keep using `something(search_properties, FindFirstFunctions.SearchProperties(t))`
directly. Adds a regression test differentiating through both values and knots
across 15 knots.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FvBXVKGujjeaCB3iLwsDeG1 parent b181e3b commit 90b22a0
2 files changed
Lines changed: 18 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
271 | 288 | | |
272 | 289 | | |
273 | 290 | | |
| |||
0 commit comments