support ForwardDiff@1.0#440
Merged
Merged
Conversation
Member
|
Can we just make those methods error then? |
Member
Author
|
we could, but they give correct results everywhere other than the interpolation transition points so I think that would be somewhat of a shame. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for ForwardDiff@1.0, but removes tests for derivatives of Bplines, since their behavior (as pointed out in #419 is already fairly buggy).
I think this is the right balance to strike, as it turns out the behavior here was always fairly wonky.