Commit 15257f9
Fix mass-matrix Rosenbrock test and raise downgrade compat floors (#462)
The CPU/JLArrays/OpenCL/QA test groups all errored on the first test,
test/gpu_kernel_de/stiff_ode/gpu_ode_mass_matrix.jl, with a
`Cannot convert StaticWOperator{Float64} to StaticWOperator{Float32}`
MethodError. The reference CPU bench solve used `dt = 0.1` (Float64) on
an otherwise all-Float32 problem (u0, p, tspan, tolerances are Float32,
and the GPU solve already uses `dt = 0.1f0`). OrdinaryDiffEqRosenbrock's
JacReuseState types its `cached_W` slot from the state eltype (Float32),
but with a Float64 dt `calc_W` builds a Float64 StaticWOperator that
cannot be stored, erroring at OrdinaryDiffEqDifferentiation
derivative_utils.jl:922 (`jac_reuse.cached_W = W`). Use a type-consistent
`dt = 0.1f0` for the bench solve; the GPU-vs-reference tolerance
assertions are unchanged. Verified locally on Julia 1.12 with GROUP=CPU:
the mass-matrix safetestset passes 2/2.
Also raise three compat floors so the Downgrade job can get past the
ModelingToolkit unsatisfiability it currently hits (StaticArrays was
pinned to its 1.9 floor at downgrade, which forced MTK below v11 while
the test pins MTK >= 11.17):
- StaticArrays 1.9 -> 1.9.14 (MTK 10.18-11 needs StaticArrays >= 1.9.14)
- SciMLBase 3 -> 3.1 (lowest MTK compatible with SciMLBase 3 is 11.22;
JumpProcesses 9.25.1+ needs SciMLBase >= 3.1.0, excluding 3.0.0)
- ModelingToolkit 11.17.0 -> 11.23.0 (test; lowest MTK consistent with
the SciMLBase 3.1 and OrdinaryDiffEqRosenbrock 2 floors)
Verified the floor set resolves on Julia 1.10 (SciMLBase 3.1.0 / MTK
11.23.0 / StaticArrays 1.9.14 / OrdinaryDiffEqRosenbrock 2.0.0) and that
normal latest-version resolution is unaffected (SciMLBase 3.21, MTK
11.28, StaticArrays 1.9.18). The Downgrade job may still hit the
pre-existing, maintainer-noted ForwardDiff/LogExpFunctions strict-floor
wall, which is an upstream issue tracked separately.
Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 373f5b7 commit 15257f9
3 files changed
Lines changed: 9 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
| 53 | + | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
38 | 41 | | |
39 | | - | |
| 42 | + | |
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
| |||
0 commit comments