Skip to content

Commit be637c6

Browse files
ChrisRackauckas-ClaudeChrisRackauckasclaude
authored
Fix QA/Core CI: drop unmatched sublibrary [sources] from test/qa/Project.toml (#201)
* Fix QA env: drop unmatched sublibrary [sources] from test/qa/Project.toml The test/qa environment listed every sublibrary (BVProblemLibrary, DAEProblemLibrary, ..., SDEProblemLibrary) under [sources] without a matching [deps]/[extras] entry. On Julia 1.12, Pkg.activate validates the project and errors: Sources for `JumpProblemLibrary` not listed in `deps` or `extras` section at ".../test/qa/Project.toml". This broke both the QA group and the Core group (Core reaches the same activate_qa_env path via the Core => QA umbrella in runtests.jl). The qa env only needs DiffEqProblemLibrary, which transitively resolves its own sublibrary [sources]; the per-sublibrary entries were spurious. Keep only the DiffEqProblemLibrary path source. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * ci: allow Comput/Collum citation false-positives in typos config The Spell Check job flagged two genuine false-positives: - "Comput" in "Math. Comput." (Mathematics of Computation journal abbreviation) in lib/DDEProblemLibrary/src/ddetst.jl - "Collum" in the surname "McCollum" (paper author) in lib/JumpProblemLibrary/src/JumpProblemLibrary.jl Add both to default.extend-words so typos accepts them. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent ff9d114 commit be637c6

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

.typos.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,7 @@ MTK = "MTK"
7575
ODE = "ODE"
7676
PDE = "PDE"
7777
SDE = "SDE"
78+
79+
# Citation false-positives
80+
Comput = "Comput" # "Math. Comput." journal abbreviation
81+
Collum = "Collum" # surname "McCollum" (paper author)

test/qa/Project.toml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,7 @@ SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
66
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
77

88
[sources]
9-
BVProblemLibrary = {path = "../../lib/BVProblemLibrary"}
10-
DAEProblemLibrary = {path = "../../lib/DAEProblemLibrary"}
11-
DDEProblemLibrary = {path = "../../lib/DDEProblemLibrary"}
129
DiffEqProblemLibrary = {path = "../.."}
13-
JumpProblemLibrary = {path = "../../lib/JumpProblemLibrary"}
14-
NonlinearProblemLibrary = {path = "../../lib/NonlinearProblemLibrary"}
15-
ODEProblemLibrary = {path = "../../lib/ODEProblemLibrary"}
16-
SDEProblemLibrary = {path = "../../lib/SDEProblemLibrary"}
1710

1811
[compat]
1912
DiffEqProblemLibrary = "5"

0 commit comments

Comments
 (0)