Fix fill! to return array instead of nothing#40
Merged
ChrisRackauckas merged 1 commit intoDec 30, 2025
Merged
Conversation
The standard Julia interface expects fill! to return the modified array, not nothing. This change aligns AlmostBandedMatrix with the standard interface. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fill!method to return the modified array instead ofnothing, aligning with Julia's standard interfaceTesting Done
Tested interface compliance with:
fast_scalar_indexingstatus; algorithms appropriately require CPU arraysfast_scalar_indexing,can_setindex, andqr_instanceAll existing tests pass.
Notes
The package has excellent interface compliance overall:
eltypeandsimilarfor type genericityArrayInterface.fast_scalar_indexingimplementationcc @ChrisRackauckas
🤖 Generated with Claude Code