Skip to content

Fix fill! to return array instead of nothing#40

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:interface-check-20251229-211636
Dec 30, 2025
Merged

Fix fill! to return array instead of nothing#40
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:interface-check-20251229-211636

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Summary

  • Fixed fill! method to return the modified array instead of nothing, aligning with Julia's standard interface

Testing Done

Tested interface compliance with:

  • BigFloat: All operations (construction, QR factorization, linear solve, similar, copy) work correctly with BigFloat element types
  • JLArrays: Package correctly reports fast_scalar_indexing status; algorithms appropriately require CPU arrays
  • ArrayInterface.jl: All compatibility checks pass including fast_scalar_indexing, can_setindex, and qr_instance

All existing tests pass.

Notes

The package has excellent interface compliance overall:

  • Proper use of eltype and similar for type genericity
  • Element type preservation through all operations
  • Correct ArrayInterface.fast_scalar_indexing implementation

cc @ChrisRackauckas

🤖 Generated with Claude Code

The standard Julia interface expects fill! to return the modified array,
not nothing. This change aligns AlmostBandedMatrix with the standard
interface.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas merged commit f99bd4e into SciML:main Dec 30, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants