QA: run_qa v1.6 form + ExplicitImports#72
Merged
ChrisRackauckas merged 1 commit intoJun 27, 2026
Merged
Conversation
Bring the QA group onto SciMLTesting 1.6's run_qa with ExplicitImports enabled, replacing the hand-rolled Aqua.test_all(...; ambiguities=false). test/qa/qa.jl: - run_qa(FastAlmostBandedMatrices; explicit_imports = true, ...). - aqua_broken = (:ambiguities,): preserves the prior `ambiguities = false` silent disable as a visible, counted @test_broken placeholder (19 real ambiguities in this package's own ldiv!/__arguments). Tracked in SciML#71. - ei_broken = (:no_implicit_imports,): 31 names used via implicit imports through the heavy `using` set + `@reexport using BandedMatrices`; the explicit-import refactor is deferred to its own PR. Tracked in SciML#71. - ei_kwargs ignore-lists for all_explicit_imports_are_public and all_qualified_accesses_are_public: upstream non-public names this package legitimately extends/uses (ArrayLayouts/BandedMatrices/MatrixFactorizations internal QR APIs; Base/LinearAlgebra/LazyArrays/ArrayInterface internals). src/FastAlmostBandedMatrices.jl (ExplicitImports FIXes -> 0 hard FAIL): - Remove 4 stale explicit imports (no_stale_explicit_imports): ArrayLayouts sub_materialize/zero!/_copyto!, BandedMatrices bandeddata. - Import QRPackedQLayout/AdjQRPackedQLayout from their owner ArrayLayouts instead of re-export MatrixFactorizations (all_explicit_imports_via_owners). test/qa/Project.toml: - Drop Aqua: with ambiguities disabled, the Aqua.test_ambiguities child process never runs, so Aqua need not be a direct dep (run_qa uses SciMLTesting's own Aqua). SafeTestsets kept (run_tests wraps the group body in @safetestset). - SciMLTesting compat -> "1.6". Verified locally against released SciMLTesting v1.6.0 (Julia 1.10 and 1.11): QA group 15 Pass / 2 Broken / 0 Fail / 0 Error; Core group unaffected (28+2 broken core_tests, 11 alloc_tests). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Brings the QA group onto SciMLTesting 1.6's
run_qav1.6 form with ExplicitImports enabled, replacing the hand-rolledAqua.test_all(FastAlmostBandedMatrices; ambiguities = false)intest/qa/qa.jl.What changed
test/qa/qa.jl: nowrun_qa(FastAlmostBandedMatrices; explicit_imports = true, ...).src/FastAlmostBandedMatrices.jl: two ExplicitImports FIXes (no source-behavior change; Core tests unaffected).test/qa/Project.toml: dropAqua(the ambiguities child-proc no longer runs, so Aqua need not be a direct dep —run_qauses SciMLTesting's own Aqua);SciMLTestingcompat ->"1.6".SafeTestsetskept becauserun_testswraps the group body in@safetestset.ExplicitImports findings (6 checks)
no_stale_explicit_importssub_materialize,zero!,_copyto!(ArrayLayouts),bandeddata(BandedMatrices).all_explicit_imports_via_ownersQRPackedQLayout/AdjQRPackedQLayoutnow imported from owner ArrayLayouts (were from re-export MatrixFactorizations).all_qualified_accesses_via_ownersall_explicit_imports_are_publicall_qualified_accesses_are_publicOneTo/array_summary/dims2string/inds2string/materialize!, LinearAlgebraQRPackedQ, LazyArraysarguments, ArrayInterfacefast_scalar_indexing/qr_instance).no_implicit_importsei_broken) — 31 names via the heavyusingset +@reexport using BandedMatrices; explicit-import refactor deferred. Tracked in #71.Aqua
aqua_broken = (:ambiguities,)preserves the prior silentambiguities = falsedisable as a visible, counted@test_brokenplaceholder. The 19 ambiguities are all in this package's ownldiv!/__argumentsmethods. Tracked in #71.Verification (released SciMLTesting v1.6.0, no dev-from-branch)
Ran the QA group exactly as CI does (
GROUP=QA,run_tests()) on Julia 1.10 and 1.11:0 Fail / 0 Error. The 2 Broken are
aqua: ambiguitiesandno_implicit_imports(both -> #71). Core group unaffected (28 pass + 2 pre-existing broken in core_tests.jl, 11 alloc_tests). Runic clean.🤖 Generated with Claude Code