Skip to content

Fix minimum version bounds and NullParameters bug #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisRackauckas-Claude wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix minimum version bounds and NullParameters bug #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"

[compat]
Catalyst = "15"
DiffEqBase = "6"
DiffEqBase = "6.165"
MacroTools = "^0.5.5"
Reexport = "1"
RuntimeGeneratedFunctions = "0.5"
Expand Down
2 changes: 1 addition & 1 deletion src/build_rhs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,6 @@ Return an `ODEProblem` for use in `DifferentialEquations`. This function implici
calls `convert(ODEFunction, sys)`. It is usually more efficient to create an `ODEFunction`
first and then use that to create `ODEProblem`s.
"""
function DiffEqBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = NullParameters())
function DiffEqBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = DiffEqBase.NullParameters())
Copy link
Copy Markdown
Member

@ChrisRackauckas ChrisRackauckas Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function DiffEqBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = DiffEqBase.NullParameters())
function SciMLBase.ODEProblem(sys::FSPSystem, u0, tint, pmap = SciMLBase.NullParameters())

ODEProblem(convert(ODEFunction, sys), u0, tint, pmap_to_p(sys, pmap))
end
2 changes: 1 addition & 1 deletion src/build_rhs_ss.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ end

Return a `SteadyStateProblem` for use in `DifferentialEquations.
"""
function DiffEqBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = NullParameters())
function DiffEqBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = DiffEqBase.NullParameters())
Copy link
Copy Markdown
Member

@ChrisRackauckas ChrisRackauckas Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function DiffEqBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = DiffEqBase.NullParameters())
function SciMLBase.SteadyStateProblem(sys::FSPSystem, u0, pmap = SciMLBase.NullParameters())

SteadyStateProblem(convert(ODEFunction, sys, SteadyState()), u0, pmap_to_p(sys, pmap))
end
Loading