Stabilize birthdeath steady-state test rates#68
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follow-up makes the
birthdeath2Dtest rates deterministic. PR #58 merged before this stabilization commit landed, and the old merged CI failures were on the random-rate version of the test.The random rates could generate stiff/ill-conditioned steady-state cases where
SSRootfind()returned distributions with large negative components, causing the Poisson marginal checks and the permuted steady-state comparison to fail. The fixed rates keep the same coverage while avoiding random pathological parameter sets.Ignore this PR until reviewed by @ChrisRackauckas.
Validation
GROUP=Core timeout 3600 julia +release --startup-file=no --project=. -e 'using Pkg; Pkg.test()'Core/birthdeath2D.jl: 18/18Core/feedbackloop.jl: 12/12Core/telegraph.jl: 17/17GROUP=QA timeout 3600 julia +release --startup-file=no --project=. -e 'using Pkg; Pkg.test()'QA/qa.jl: 15 pass, 4 brokengit diff --checkRunic --check test/birthdeath2D.jlNote: a direct include under the repo root manifest failed before reaching this test because the checked-in root manifest resolves an incompatible OrdinaryDiffEq stack. The package test path re-resolved a fresh temp test environment and passed.