Skip to content

Commit 46bb453

Browse files
QA: drop now-public EI ignores (SciMLTesting 1.7 + base-lib public APIs)
SciMLTesting 1.7.0 runs the two public-API ExplicitImports checks (check_all_qualified_accesses_are_public and check_all_explicit_imports_are_public) only on Julia >= 1.11 and skips them on the lts. Combined with the base-lib public-API releases (SciMLBase 3.24.0, CommonSolve 0.2.9), the per-repo public-API ignore entries this PR carried are now redundant. Empty both public-API ignore-lists in test/qa/qa.jl: the previously ignored AutoSpecialize (SciMLBase), init (CommonSolve), and solve (CommonSolve) are all recognized as public on the registered releases, so run_qa(...; explicit_imports = true) passes with no ei_kwargs at all. Verified against registered releases (no dev of base libs; FVM dev'd from this working tree): - Julia 1.12 (public-API checks RUN): QA group 18/18 pass, 0 fail/ error/broken; resolved SciMLTesting 1.7.0, SciMLBase 3.24.0, CommonSolve 0.2.9, ExplicitImports 1.15.0. - Julia 1.10 lts (public-API checks skipped by SciMLTesting 1.7): QA group 16/16 pass, 0 fail/error/broken. No names needed restoring; the ignore-lists are now empty. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent cead5d8 commit 46bb453

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

test/qa/qa.jl

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,4 @@ using JET
44
run_qa(
55
FiniteVolumeMethod1D;
66
explicit_imports = true,
7-
ei_kwargs = (;
8-
# Other packages' not-yet-public names; ignore until they go public.
9-
all_qualified_accesses_are_public = (;
10-
ignore = (
11-
:AutoSpecialize, # SciMLBase.AutoSpecialize (specialization default)
12-
:init, # CommonSolve.init (extended/forwarded here)
13-
),
14-
),
15-
all_explicit_imports_are_public = (;
16-
ignore = (:solve,), # CommonSolve.solve (re-exported)
17-
),
18-
),
197
)

0 commit comments

Comments
 (0)