Skip to content

Spellcheck: fix typos / extend allowlist#86

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix-spellcheck
Jun 13, 2026
Merged

Spellcheck: fix typos / extend allowlist#86
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix-spellcheck

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Fixes the failing Spell Check (crate-ci/typos@v1.47.0) CI.

Root cause: the repo had both _typos.toml (containing only a Manifest exclude) and a comprehensive .typos.toml allowlist. typos reads _typos.toml in preference to .typos.toml, so the allowlist was never applied (typos --dump-config confirmed [default.extend-words] was empty). Spellcheck then failed on neum.

Fix: consolidate into the single canonical .typos.toml:

  • Fold the Manifest exclude into .typos.toml (the docs/ and test/ Manifest.toml are tracked).
  • Allowlist neum — a local variable abbreviating "Neumann" boundary condition in test/boundary_conditions.jl (paired with dirc for Dirichlet); a false positive, not a code-identifier change.
  • Remove the redundant _typos.toml so the allowlist is actually applied.

typos now exits 0 with zero findings (verified locally with 1.47.0).

Ignore until reviewed by @ChrisRackauckas.

The CI typos run read _typos.toml (only a Manifest exclude), which shadowed
the comprehensive .typos.toml allowlist, so spellcheck failed on `neum`.
Consolidate into the single canonical .typos.toml: fold in the Manifest
exclude and allowlist `neum` (local variable abbreviating "Neumann" in
test/boundary_conditions.jl, a false positive), and remove the redundant
_typos.toml so the allowlist is actually applied.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 13, 2026 08:58
@ChrisRackauckas ChrisRackauckas merged commit 0dbed24 into SciML:main Jun 13, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants