Use SciMLTesting v1.2 (folder-based run_tests)#88
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert test/runtests.jl to the SciMLTesting v1.2 folder-discovery model: `using SciMLTesting; run_tests()`. Groups Core + QA from test_groups.toml. - Core = the 9 top-level test/*.jl the old GROUP=Core/All dispatch ran. The dormant (commented-out) fisher.jl is moved to test/shared/ so the Core glob does not start running it. - QA = the existing test/qa/ (qa.jl + Project.toml), auto-activated as a sub-env. - Core files: `using ..FiniteVolumeMethod1D` -> `using FiniteVolumeMethod1D` (the bare run_tests() no longer loads the package into Main; the absolute import resolves in the Pkg.test test env). No assertions changed. - test/Project.toml: add SciMLTesting (+compat) and SafeTestsets/Test compat; drop Pkg (no test/*.jl uses it; the harness owns all Pkg ops). - test/qa/Project.toml: add SciMLTesting + SafeTestsets (+compat); drop Pkg. - Remove the stale checked-in test/Manifest.toml (already inconsistent on main) and gitignore it; the grouped-tests CI re-resolves the test env. Validated locally on julia 1.11 via Pkg.test: GROUP=Core (all 9 files pass) and GROUP=QA (7 pass, 2 @test_broken, matching the prior qa.jl behavior). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
81ea261 to
72ce96a
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2 folder-discovery model:test/test_groups.toml(Core + QA) is the single source of truth; groups map to folders.Layout
test/*.jlthe oldGROUP=Core/Alldispatch ran (run flat, each in its own@safetestset). The dormant, commented-outfisher.jlis moved totest/shared/so the Core glob does not start running it (behavior-preserving — it was never run).test/qa/(qa.jl+Project.toml), auto-activated as a sub-env by the harness.qa.jlis unchanged (keeps its two@test_brokenmarkers for the Aqua deps_compat / JET issues tracked in QA: Aqua/JET findings marked @test_broken pending fix #84).Changes
using ..FiniteVolumeMethod1D→using FiniteVolumeMethod1D. The barerun_tests()no longer loads the package intoMain(the old hand-written runtests did), so the absolute import is what resolves inside thePkg.testtest env. No assertions changed.test/Project.toml: addSciMLTesting(+ compat) andSafeTestsets/Testcompat; dropPkg(notest/*.jluses it; the harness owns allPkgops).test/qa/Project.toml: addSciMLTesting+SafeTestsets(+ compat); dropPkg;[sources]kept relative.test/Manifest.toml(it is already inconsistent with the project onmain, so CI must re-resolve regardless) and gitignored it.test/test_groups.tomlunchanged.Validation
Validated locally on Julia 1.11 via
Pkg.test:GROUP=Core— all 9 files pass.GROUP=QA— 7 pass, 2@test_broken(matches the priorqa.jlbehavior; exercises the sub-env activation path).This supersedes the v1.0.0
run_testsharness form previously on this branch.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code