diff --git a/.gitignore b/.gitignore index eb3bd20..2878906 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ /Manifest.toml /test/Manifest.toml +/test/qa/Manifest.toml /docs/build/ diff --git a/Project.toml b/Project.toml index 6f204bc..49a44c7 100644 --- a/Project.toml +++ b/Project.toml @@ -11,15 +11,14 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" [compat] CommonSolve = "0.2" -ExplicitImports = "1" PrecompileTools = "1" SciMLBase = "2.146, 3.1" +SparseArrays = "1" Test = "1" julia = "1.10" [extras] -ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7" Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" [targets] -test = ["ExplicitImports", "Test"] +test = ["Test"] diff --git a/test/Project.toml b/test/Project.toml index 457b695..bac0c25 100644 --- a/test/Project.toml +++ b/test/Project.toml @@ -1,7 +1,6 @@ [deps] CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0" DomainSets = "5b8099bc-c8ec-5219-889f-1d9e522a28bf" -ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7" LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae" MethodOfLines = "94925ecb-adb7-4558-8ed8-f975c56a0bf4" diff --git a/test/explicit_imports.jl b/test/explicit_imports.jl deleted file mode 100644 index 6d9e7ac..0000000 --- a/test/explicit_imports.jl +++ /dev/null @@ -1,6 +0,0 @@ -using ExplicitImports -using FiniteVolumeMethod1D -using Test - -@test check_no_implicit_imports(FiniteVolumeMethod1D) === nothing -@test check_no_stale_explicit_imports(FiniteVolumeMethod1D) === nothing diff --git a/test/qa/Project.toml b/test/qa/Project.toml index fd710c8..905689c 100644 --- a/test/qa/Project.toml +++ b/test/qa/Project.toml @@ -13,6 +13,6 @@ FiniteVolumeMethod1D = {path = "../.."} Aqua = "0.8" JET = "0.9,0.10,0.11" SafeTestsets = "0.0.1, 0.1" -SciMLTesting = "1" +SciMLTesting = "1.7" Test = "1" julia = "1.10" diff --git a/test/qa/qa.jl b/test/qa/qa.jl index 680a68c..a1f1b4d 100644 --- a/test/qa/qa.jl +++ b/test/qa/qa.jl @@ -1,20 +1,7 @@ -using FiniteVolumeMethod1D -using Aqua +using SciMLTesting, FiniteVolumeMethod1D, Test using JET -using Test -@testset "Quality Assurance" begin - @testset "Aqua" begin - # All Aqua sub-checks pass except deps_compat, which is marked broken below. - Aqua.test_all(FiniteVolumeMethod1D; deps_compat = false) - # deps_compat fails: SparseArrays is a dep with no [compat] entry. - # See https://github.com/SciML/FiniteVolumeMethod1D.jl/issues/84 - @test_broken false # Aqua deps_compat: SparseArrays missing [compat] — see #84 - end - @testset "JET" begin - # JET.report_package reports 4 possible errors (Dirichlet/Neumann kwdef - # inner ctors and CommonSolve.init on the constructed ODEProblem). - # See https://github.com/SciML/FiniteVolumeMethod1D.jl/issues/84 - @test_broken false # JET: report_package errors — see #84 - end -end +run_qa( + FiniteVolumeMethod1D; + explicit_imports = true, +)