Skip to content

QA: run_qa v1.6 form + ExplicitImports #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 3 commits into from
Jul 2, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cead5d8
QA: run_qa v1.6 form + ExplicitImports
ChrisRackauckas Jun 25, 2026
46bb453
QA: drop now-public EI ignores (SciMLTesting 1.7 + base-lib public APIs)
ChrisRackauckas Jun 26, 2026
467ec2d
QA: pin SciMLTesting compat floor to 1.7 (public-API EI gate)
ChrisRackauckas Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/Manifest.toml
/test/Manifest.toml
/test/qa/Manifest.toml
/docs/build/
5 changes: 2 additions & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,14 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"

[compat]
CommonSolve = "0.2"
ExplicitImports = "1"
PrecompileTools = "1"
SciMLBase = "2.146, 3.1"
SparseArrays = "1"
Test = "1"
julia = "1.10"

[extras]
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["ExplicitImports", "Test"]
test = ["Test"]
1 change: 0 additions & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[deps]
CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0"
DomainSets = "5b8099bc-c8ec-5219-889f-1d9e522a28bf"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
MethodOfLines = "94925ecb-adb7-4558-8ed8-f975c56a0bf4"
Expand Down
6 changes: 0 additions & 6 deletions test/explicit_imports.jl
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ FiniteVolumeMethod1D = {path = "../.."}
Aqua = "0.8"
JET = "0.9,0.10,0.11"
SafeTestsets = "0.0.1, 0.1"
SciMLTesting = "1"
SciMLTesting = "1.7"
Test = "1"
julia = "1.10"
23 changes: 5 additions & 18 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,7 @@
using FiniteVolumeMethod1D
using Aqua
using SciMLTesting, FiniteVolumeMethod1D, Test
using JET
using Test

@testset "Quality Assurance" begin
@testset "Aqua" begin
# All Aqua sub-checks pass except deps_compat, which is marked broken below.
Aqua.test_all(FiniteVolumeMethod1D; deps_compat = false)
# deps_compat fails: SparseArrays is a dep with no [compat] entry.
# See https://github.com/SciML/FiniteVolumeMethod1D.jl/issues/84
@test_broken false # Aqua deps_compat: SparseArrays missing [compat] — see #84
end
@testset "JET" begin
# JET.report_package reports 4 possible errors (Dirichlet/Neumann kwdef
# inner ctors and CommonSolve.init on the constructed ODEProblem).
# See https://github.com/SciML/FiniteVolumeMethod1D.jl/issues/84
@test_broken false # JET: report_package errors — see #84
end
end
run_qa(
FiniteVolumeMethod1D;
explicit_imports = true,
)
Loading