Skip to content

Commit 4bc1076

Browse files
Drop the dead TruncatedStacktraces dependency
`@truncate_stacktrace` cannot fire in this package. TruncatedStacktraces sets `DISABLE = @load_preference("disable", true) || VERSION >= v"1.10"`, and the macro body is wrapped in `@static if !DISABLE`, so on Julia 1.10 and later it expands to nothing — and 1.10 is this package's floor. The `Base.show` method it is supposed to define has never existed on any Julia version we support, and the preference cannot override the version clause. Verified: `FunctionWrappersWrapper` contributes zero `Base.show` methods, and its type prints in full with no truncation. That makes the dependency dead weight, and it was the only reason the QA suite needed a `@truncate_stacktrace` ignore. Removing it is better than either ignoring the access or promoting the name upstream — the latter is impossible in any case, since SciML/TruncatedStacktraces.jl is archived and read-only. Only the `FunctionWrapper` ignore remains, and that one has a path out now: JuliaLang/FunctionWrappers.jl#35. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
1 parent ee57b5a commit 4bc1076

6 files changed

Lines changed: 647 additions & 28 deletions

File tree

Project.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
name = "FunctionWrappersWrappers"
22
uuid = "77dc65aa-8811-40c2-897b-53d922fa7daf"
33
authors = ["Chris Elrod <elrodc@gmail.com> and contributors"]
4-
version = "1.11.0"
4+
version = "1.11.1"
55

66
[deps]
77
FunctionWrappers = "069b7b12-0de2-55c6-9aab-29f3d0a68a2e"
88
PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
99
SciMLPublic = "431bcebd-1456-4ced-9d72-93c2757fff0b"
10-
TruncatedStacktraces = "781d530d-4396-4725-bb49-402e4bee1e77"
1110

1211
[weakdeps]
1312
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9"
@@ -28,7 +27,6 @@ SafeTestsets = "0.1, 1"
2827
SciMLPublic = "1"
2928
SciMLTesting = "2.4"
3029
Test = "1"
31-
TruncatedStacktraces = "1.1"
3230
julia = "1.10"
3331

3432
[extras]

src/FunctionWrappersWrappers.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ module FunctionWrappersWrappers
22

33
using FunctionWrappers: FunctionWrappers
44
using SciMLPublic: @public
5-
import TruncatedStacktraces
65

76
export FunctionWrappersWrapper, unwrap, wrapped_signatures, wrapped_return_types
87
export NoCache, SingleCache, DictCache
@@ -223,8 +222,6 @@ struct FunctionWrappersWrapper{FW, P, CS}
223222
end
224223
end
225224

226-
TruncatedStacktraces.@truncate_stacktrace FunctionWrappersWrapper
227-
228225
"""
229226
FunctionWrappersWrapper{FW, P, CS}(f) -> FunctionWrappersWrapper{FW, P, CS}
230227

0 commit comments

Comments
 (0)