Skip to content

Commit ee57b5a

Browse files
Restore the ExplicitImports ignores dropped in #76
#76 replaced the whole `run_qa(...)` call with a bare `run_qa(FunctionWrappersWrappers)`, which silently discarded the `all_qualified_accesses_are_public` ignore list it carried. The QA group has errored on `main` ever since with `NonPublicQualifiedAccessException` for `FunctionWrappers.FunctionWrapper` and `TruncatedStacktraces.@truncate_stacktrace`. Both are irreducible rather than "not promoted yet", and the comment now says so. `FunctionWrapper` is the type this package exists to wrap — it is in the signature of every public constructor and callers must build the tuples themselves — and FunctionWrappers.jl is JuliaLang-owned. `@truncate_stacktrace` is never exported by TruncatedStacktraces, and that repository is archived and read-only, so it cannot be promoted at its source. `:tail` is not restored: `Base.tail` is no longer reached, and ExplicitImports does not flag it. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
1 parent 588bcb7 commit ee57b5a

2 files changed

Lines changed: 336 additions & 1 deletion

File tree

test/qa/Manifest.toml

Lines changed: 319 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/qa/qa.jl

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
11
using SciMLTesting, FunctionWrappersWrappers
22

3-
run_qa(FunctionWrappersWrappers)
3+
run_qa(
4+
FunctionWrappersWrappers;
5+
ei_kwargs = (;
6+
# Qualified accesses to names their owning module has not declared `public`.
7+
# Both are irreducible — neither can be promoted at its source:
8+
# FunctionWrappers.FunctionWrapper is the type this package exists to wrap. It
9+
# appears in the signature of every public constructor, and callers must build
10+
# `FunctionWrapper` tuples themselves to reach the inference-stable path, so it
11+
# cannot be hidden. FunctionWrappers.jl is JuliaLang-owned.
12+
# TruncatedStacktraces.@truncate_stacktrace is that package's only user-facing
13+
# macro and is never exported. SciML/TruncatedStacktraces.jl is archived and
14+
# read-only, so it cannot be made public there.
15+
all_qualified_accesses_are_public = (;
16+
ignore = (:FunctionWrapper, Symbol("@truncate_stacktrace")),
17+
),
18+
),
19+
)

0 commit comments

Comments
 (0)