Centralize CI on SciML reusable workflows#53
Merged
Conversation
Convert all CI to the SciML centralized reusable workflows (pinned @v1, secrets: inherit on every caller). - Tests: already a tests.yml@v1 caller (unchanged matrix; secrets already inherit). Moved the inline Documentation job out into its own workflow. - Documentation: new documentation.yml@v1 caller (replaces inline docdeploy job). - Runic (FormatCheck): convert inline fredrikekre/runic-action to runic.yml@v1. - SpellCheck: new spellcheck.yml@v1 caller (was previously not present). - Downgrade: new downgrade.yml@v1 caller (julia-version lts, skip Pkg,TOML, group Core). - dependabot: remove the crate-ci/typos ignore (typos now runs via centralized caller). - Apply Runic formatting to ext/ and test/ sources. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Converts all CI to the SciML centralized reusable workflows (pinned
@v1,secrets: "inherit"on every caller). Target end-state matches Sundials.jl: Tests, Documentation, Runic, SpellCheck, Downgrade — all via centralized callers.Converted (inline -> central)
docsjob (julia-buildpkg + julia-docdeploy + standalone doctest) that lived insideTests.ymlis moved out into a newDocumentation.ymlcallingdocumentation.yml@v1.FormatCheck.yml): inlinefredrikekre/runic-actionconverted torunic.yml@v1.Added (new central callers)
spellcheck.yml@v1(repo previously had no spellcheck workflow; dependabot referenced typos but no workflow ran it).downgrade.yml@v1(julia-version: lts,skip: "Pkg,TOML",group: Core).Unchanged
tests.yml@v1caller withsecrets: "inherit"; matrix (group: [Core, nopre]×version: ['1','lts','pre']×arch: [x64], excludingpre×nopre) preserved exactly. Only change is removal of the inline docs job.Cleanup
dependabot.yml: removed thecrate-ci/typosignore entry (typos now runs through the centralized spellcheck caller). Thegithub-actions(/, weekly) andjulia(/,/docs,/test, daily, group all-julia-packages*) blocks are preserved.Formatting / typos
ext/FunctionWrappersWrappersEnzymeExt.jlandtest/enzyme_tests.jl(multiline signature indentation, operator spacing, trailing whitespace, final newline). The previous inline runic-action was evidently not passing on these files.typos .exits clean).Note on doctests
The old inline docs job ran an extra explicit
doctest(FunctionWrappersWrappers)step in addition to docdeploy. The centralizeddocumentation.yml@v1runsdocs/make.jl, whosemakedocsruns doctests by default — so doctest coverage is preserved. If a separate non-deploy doctest gate is desired, that can be added later.Heads-up: check names change
Branch-protection required-status-check names will change (jobs now run as reusable-workflow callers). Required checks in branch protection will need updating after merge.
🤖 Generated with Claude Code