Canonical CI: grouped-tests.yml + root test/test_groups.toml#57
Merged
ChrisRackauckas merged 1 commit intoJun 8, 2026
Merged
Conversation
Convert the root Tests.yml test job to the canonical thin caller of
SciML/.github grouped-tests.yml@v1, with the group x version matrix
declared once in test/test_groups.toml. The runtests.jl GROUP dispatch
(Core/nopre) already exists, so no test-runner change is needed.
The emitted root matrix reproduces the old hand-maintained matrix exactly
(5/5): Core on {lts,1,pre} and nopre on {lts,1}.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the root test workflow (
Tests.yml) to the canonical thin caller ofSciML/.githubgrouped-tests.yml@v1, with the test matrix declared once in a roottest/test_groups.toml.Changes
.github/workflows/Tests.yml: the hand-maintainedgroup x versionmatrix test job is replaced with the thin caller:on:triggers,concurrency:, filename, and top-levelname: "Tests"are preserved verbatim so the branch-protection status check is unaffected.test/test_groups.toml(new): declares the matrixNo
with:inputs are needed:runtests.jlreads the standardGROUPenv var (defaultgroup-env-name), coverage stays on,check-boundsstays at the defaultyes(the old caller also used the default), andcoverage-directoriesstays at the defaultsrc,ext. Linux-only, so noosaxis is added (defaultubuntu-latest, matching the oldarch: x64onubuntu-latest).This is a Category A conversion: the
Core/nopreGROUPdispatch already exists intest/runtests.jl, so there is no test-runner change and no new local Aqua/QA run was required.Matrix match
Verified with
compute_affected_sublibraries.jl --root-matrix(fromSciML/.github@v1). The emitted(group, version)set reproduces the old workflow matrix exactly, 5/5:All runners are
ubuntu-latest. TOML and YAML both parse cleanly.QA findings
None. No metadata fixes were needed (
[compat] juliais already at the1.10LTS floor;[extras]/[targets].testare aligned). No source-level Aqua/JET issues to report.Note (not addressed here, pre-existing):
runtests.jlalso hasEnzymeandMooncakeGROUPbranches that only run underGROUP=All. The oldTests.ymlmatrix never dispatchedAll/Enzyme/Mooncake, so those extension testsets did not run in CI before this PR either. To keep this an exact, behavior-preserving matrix conversion, they are intentionally not added here; expanding CI to cover them can be a separate change.Ignore until reviewed by @ChrisRackauckas.