Skip to content

Fix the QA regression from #76 and drop the dead TruncatedStacktraces dependency #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisRackauckas-Claude wants to merge 2 commits into from
Closed

Fix the QA regression from #76 and drop the dead TruncatedStacktraces dependency #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eabce0c
Restore the ExplicitImports ignores dropped in #76
ChrisRackauckas Jul 29, 2026
a552d4d
Drop the dead TruncatedStacktraces dependency
ChrisRackauckas Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
name = "FunctionWrappersWrappers"
uuid = "77dc65aa-8811-40c2-897b-53d922fa7daf"
authors = ["Chris Elrod <elrodc@gmail.com> and contributors"]
version = "1.11.0"
version = "1.11.1"

[deps]
FunctionWrappers = "069b7b12-0de2-55c6-9aab-29f3d0a68a2e"
PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
SciMLPublic = "431bcebd-1456-4ced-9d72-93c2757fff0b"
TruncatedStacktraces = "781d530d-4396-4725-bb49-402e4bee1e77"

[weakdeps]
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9"
Expand All @@ -28,7 +27,6 @@ SafeTestsets = "0.1, 1"
SciMLPublic = "1"
SciMLTesting = "2.4"
Test = "1"
TruncatedStacktraces = "1.1"
julia = "1.10"

[extras]
Expand Down
3 changes: 0 additions & 3 deletions src/FunctionWrappersWrappers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ module FunctionWrappersWrappers

using FunctionWrappers: FunctionWrappers
using SciMLPublic: @public
import TruncatedStacktraces

export FunctionWrappersWrapper, unwrap, wrapped_signatures, wrapped_return_types
export NoCache, SingleCache, DictCache
Expand Down Expand Up @@ -223,8 +222,6 @@ struct FunctionWrappersWrapper{FW, P, CS}
end
end

TruncatedStacktraces.@truncate_stacktrace FunctionWrappersWrapper

"""
FunctionWrappersWrapper{FW, P, CS}(f) -> FunctionWrappersWrapper{FW, P, CS}

Expand Down
14 changes: 13 additions & 1 deletion test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
using SciMLTesting, FunctionWrappersWrappers

run_qa(FunctionWrappersWrappers)
run_qa(
FunctionWrappersWrappers;
ei_kwargs = (;
# `FunctionWrappers.FunctionWrapper` is not declared `public` in its owning
# module. It is the type this package exists to wrap: it appears in the
# signature of every public constructor, and callers must build
# `FunctionWrapper` tuples themselves to reach the inference-stable
# construction path, so it cannot be hidden behind our own API. Drop this
# entry once JuliaLang/FunctionWrappers.jl#41 is released and the compat
# floor is raised.
all_qualified_accesses_are_public = (; ignore = (:FunctionWrapper,)),
),
)
Loading