Fix the FunctionWrappers PR reference in the QA ignore comment - #81
Merged
ChrisRackauckas merged 1 commit intoJul 29, 2026
Merged
Conversation
The comment pointed at JuliaLang/FunctionWrappers.jl#41, which does not exist — it was a placeholder written before the PR was opened and never corrected. The PR that marks `FunctionWrapper` public, and therefore the one that lets this ignore entry be dropped, is JuliaLang/FunctionWrappers.jl#35. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 29, 2026 03:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line comment fix. The
all_qualified_accesses_are_publicignore entry added in #79 says theFunctionWrapperexception can be dropped "once JuliaLang/FunctionWrappers.jl#41 is released".#41 does not exist —
gh api repos/JuliaLang/FunctionWrappers.jl/issues/41returns 404. It was a placeholder I wrote while drafting the comment, before opening the upstream PR, and I never went back and corrected it.The PR that actually marks
FunctionWrapperpublic, and therefore the one that lets this entry go away, is JuliaLang/FunctionWrappers.jl#35.No code change. QA still green on this branch:
Links