Commit fca13bd
committed
Route solver warnings through DEVerbosity instead of
DiffEqBase v7 passes `verbose` as a `DEVerbosity` object. Even silent
modes like `DEVerbosity(None())` are not `===false`, so the prior
`verbose !== false` guard always admitted warnings and ignored the
caller's silence request.
- Route every compat warning (unsupported kwargs, explicit t-gradient /
Jacobian on stiff solvers, compat-chart link) through `@SciMLMessage`.
`@SciMLMessage` handles both `Bool` (true→WarnLevel, false→Silent)
and `AbstractVerbositySpecifier` (reads the named toggle), so v6
callers and v7 callers are both honored.
- Use the `:mismatched_input_output_type` toggle from `DEVerbosity`,
which is the right bucket for "input the GeometricIntegrators solver
cannot honor" messages.
- Inline the `check_keywords` loop since the SciMLBase helper always
`@warn`s and can't be parameterized by verbosity.
- Add `SciMLLogging` as a direct dep for `@SciMLMessage`.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>verbose !== false
1 parent 3e13835 commit fca13bd
3 files changed
Lines changed: 43 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | 18 | | |
23 | 19 | | |
24 | 20 | | |
25 | 21 | | |
26 | 22 | | |
27 | 23 | | |
28 | 24 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
40 | 51 | | |
41 | | - | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
42 | 65 | | |
43 | 66 | | |
44 | 67 | | |
| |||
0 commit comments