Skip to content

Commit bc79223

Browse files
Merge pull request #944 from ChrisRackauckas-Claude/fix/runic-and-typo-tests
Fix runic and typos CI failures
2 parents 2786f3e + b1754b9 commit bc79223

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

ext/LinearSolveEnzymeExt.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -165,10 +165,10 @@ function _sparse_outer_sub!(
165165
# `Symmetric` disallows writing off-diagonal entries via `setindex!` on the wrapper.
166166
# Accumulate directly into the parent storage while preserving symmetry by updating
167167
# only the stored triangle with the reduced gradient for unique symmetric entries.
168-
Aparent = parent(dA)
169-
n = size(Aparent, 1)
168+
A_parent = parent(dA)
169+
n = size(A_parent, 1)
170170

171-
@assert size(Aparent, 1) == size(Aparent, 2)
171+
@assert size(A_parent, 1) == size(A_parent, 2)
172172
@assert length(z) == n
173173
@assert length(y) == n
174174

@@ -177,17 +177,17 @@ function _sparse_outer_sub!(
177177
zj = z[j]
178178
yj = y[j]
179179
for i in 1:(j - 1)
180-
Aparent[i, j] -= z[i] * yj + zj * y[i]
180+
A_parent[i, j] -= z[i] * yj + zj * y[i]
181181
end
182-
Aparent[j, j] -= zj * yj
182+
A_parent[j, j] -= zj * yj
183183
end
184184
else
185185
@inbounds for j in 1:n
186186
zj = z[j]
187187
yj = y[j]
188-
Aparent[j, j] -= zj * yj
188+
A_parent[j, j] -= zj * yj
189189
for i in (j + 1):n
190-
Aparent[i, j] -= z[i] * yj + zj * y[i]
190+
A_parent[i, j] -= z[i] * yj + zj * y[i]
191191
end
192192
end
193193
end

test/nopre/mooncake.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,5 +295,5 @@ end
295295
fA_closure = A -> fnice(A, b1, alg)
296296
fd_jac_A = FiniteDiff.finite_difference_jacobian(fA_closure, A) |> vec
297297
A_grad = en_jac[2] |> vec
298-
@test A_grad fd_jac_A rtol = 1e-4
298+
@test A_grad fd_jac_A rtol = 1.0e-4
299299
end

0 commit comments

Comments
 (0)