Use separate cache flags for A and b in ForwardDiff extension#1054
Closed
hersle wants to merge 1 commit into
Closed
Use separate cache flags for A and b in ForwardDiff extension#1054hersle wants to merge 1 commit into
hersle wants to merge 1 commit into
Conversation
Member
|
This needs tests. |
ChrisRackauckas
added a commit
that referenced
this pull request
Jun 26, 2026
…#1054 + test) (#1062) * Use separate cache flags for A and b (faster when only one changes) * Test separate A/b partials validity flags in DualLinearCache Verify that mutating only A or only b invalidates that side's partials list independently, that solving revalidates both, and that the result stays correct across one-sided updates. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> --------- Co-authored-by: Herman Sletmoen <hermansletmoen@gmail.com> Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
Member
|
Rebased and finished in #1062, just needed to update but basically was taken in as-is with your commit. |
Contributor
Author
|
That's ok, thanks a lot for following it through! I appreciate it, as my time to follow up is a bit limited :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids updating A if only b changes (e.g. in an ODE) and vice versa.