Skip to content

Qualify issuccess as LinearAlgebra.issuccess to fix QA ExplicitImports failure#1081

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix-qa-issuccess-implicit-import
Jul 11, 2026
Merged

Qualify issuccess as LinearAlgebra.issuccess to fix QA ExplicitImports failure#1081
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:fix-qa-issuccess-implicit-import

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Note: This PR should be ignored until reviewed by @ChrisRackauckas.

Problem

The QA test group (GROUP=QA) fails on main in ExplicitImports' no_implicit_imports check:

no_implicit_imports: Error During Test at .../SciMLTesting/y2DHi/src/SciMLTesting.jl:816
  Test threw exception
  Expression: check(pkg; get(ei_kwargs, name, (;))...) === nothing
  ImplicitImportsException
  Module `LinearSolve` is relying on the following implicit imports:
  * `issuccess` which is exported by `LinearAlgebra`

Test Summary:                                  | Pass  Error  Broken  Total   Time
Quality Assurance                              |   14      1       2     17  45.4s
...
    ExplicitImports                            |    4      1       1      6  18.2s
      no_implicit_imports                      |           1              1   4.5s
ERROR: Package LinearSolve errored during testing

Cause

Commit c75997b (#1078, GESVFactorization + dense LU pivot-buffer reuse) added an unqualified if !issuccess(luf) in SciMLBase.solve!(cache::LinearCache, alg::GESVFactorization) in src/factorization.jl. issuccess is not explicitly imported, so ExplicitImports flags it as an implicit import from LinearAlgebra.

Fix

One-line change: qualify the call as LinearAlgebra.issuccess(luf), matching the existing qualified use earlier in the same file.

Verification

GROUP=QA run with this fix, Julia 1.12 (the 2 broken entries are pre-existing):

Test Summary:     | Pass  Broken  Total   Time
Quality Assurance |   15       2     17  41.1s
Test Summary: | Pass  Broken  Total   Time
JET Tests     |   27       8     35  45.4s
     Testing LinearSolve tests passed

🤖 Generated with Claude Code

Fixes the QA group's ExplicitImports no_implicit_imports failure
introduced in c75997b (SciML#1078), which added an unqualified
issuccess call. Matches the qualified use elsewhere in the file.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 11, 2026 09:21
@ChrisRackauckas
ChrisRackauckas merged commit c4ebafe into SciML:main Jul 11, 2026
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants