Qualify issuccess as LinearAlgebra.issuccess to fix QA ExplicitImports failure#1081
Merged
ChrisRackauckas merged 1 commit intoJul 11, 2026
Conversation
Fixes the QA group's ExplicitImports no_implicit_imports failure introduced in c75997b (SciML#1078), which added an unqualified issuccess call. Matches the qualified use elsewhere in the file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 11, 2026 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR should be ignored until reviewed by @ChrisRackauckas.
Problem
The QA test group (
GROUP=QA) fails onmainin ExplicitImports'no_implicit_importscheck:Cause
Commit c75997b (#1078, GESVFactorization + dense LU pivot-buffer reuse) added an unqualified
if !issuccess(luf)inSciMLBase.solve!(cache::LinearCache, alg::GESVFactorization)insrc/factorization.jl.issuccessis not explicitly imported, so ExplicitImports flags it as an implicit import from LinearAlgebra.Fix
One-line change: qualify the call as
LinearAlgebra.issuccess(luf), matching the existing qualified use earlier in the same file.Verification
GROUP=QArun with this fix, Julia 1.12 (the 2 broken entries are pre-existing):🤖 Generated with Claude Code