Skip to content

Skip KrylovPreconditioners in downgrade promotion#1091

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/skip-krylovpreconditioners-downgrade-resolver
Jul 15, 2026
Merged

Skip KrylovPreconditioners in downgrade promotion#1091
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:codex/skip-krylovpreconditioners-downgrade-resolver

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Please ignore this PR until it has been reviewed by @ChrisRackauckas.

Summary

Keep KrylovPreconditioners out of the joint minimum-version promotion in the downgrade workflow, alongside the existing fleet-wide Mooncake exception.

Root cause and impact

Resolver.jl cannot minimum-resolve KrylovPreconditioners' historical Arpack/LightGraphs dependency graph. This is a resolver limitation in an old transitive graph, not a LinearSolve runtime incompatibility. The package remains installed at a compatible version for tests; all other promoted dependencies continue to be floor-tested.

Local validation

  • Ran the exact Julia 1.10 downgrade resolver with no_promote=Mooncake,KrylovPreconditioners.
  • Ran the locked LINEARSOLVE_TEST_GROUP=Core suite and observed exit code 0 with LinearSolve tests passed.
  • Ran julia -m Runic --check --diff --verbose .: all 142 Julia files passed.
  • Ran actionlint .github/workflows/Downgrade.yml and git diff --check: both passed.

Process

Reproduced the resolver failure at the current default-branch SHA, isolated it from the runtime tests, applied the narrow workflow input exception, and reran the full root Core downgrade suite.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 15, 2026 20:47
@ChrisRackauckas
ChrisRackauckas merged commit 0496f13 into SciML:main Jul 15, 2026
51 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants