test: spell out SupernodalLU threshold variable - #1124
Conversation
|
Scratchpad plan and evidence:
No test was skipped, disabled, or loosened. |
|
CI triage update: |
|
Resolver follow-up ownership/status: no additional OrdinaryDiffEq code PR is needed. SciML/OrdinaryDiffEq.jl#3991 is already merged and superseded closed #3984 verbatim. The clean-main downstream resolver remains blocked while the corresponding General registrations are pending: JuliaRegistries/General#162154 (OrdinaryDiffEqDefault v2.4.0) and JuliaRegistries/General#162158 (OrdinaryDiffEqFIRK v2.5.0). The staged registry metadata has been reproduced separately as resolving/importing with LinearSolve 5.3.1; its exact Core validations are still running. This remains independent of #1124. |
|
Resolver status update: JuliaRegistries/General#162154 ( |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
85b1c9d to
79b618e
Compare
|
Terminal CI checkpoint for rebased head
The branch-specific checks, including Typos, Core, Runic, and the affected SupernodalLU testset, are green. This PR remains a focused clean-main typo fix. |
|
The downstream ModelingToolkit Julia 1.10 initialization failures have now been split precisely:
#4852 is a draft pending CI/review; this link is classification, not a claim that this PR's full matrix is green yet. |
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
Rename the local
thrloop variable in the SupernodalLU dense-kernel tests tothresholdso Typos does not interpret it as a misspelling.Regression evidence
main(ed7bcb014f03d15f50e9a5cf86f8a314ab2d248d) reports exactly two Typos 1.48.0 findings attest/Core/supernodal_lu.jl:176-177.4c58ce272a79969d45eaa640bdf74c2a437263bf(SupernodalLU: fix block factorization on the direct-BLAS backends #1119) as the first bad commit.Local verification
The rebased #1124 tree is byte-identical to the separately tested current-main validation tree (
a11cb43039569967e2bd97e862cf6b32a5b1ba5c):GROUP=Core JULIA_NUM_THREADS=2 julia +1.12 --project=. -e 'using Pkg; Pkg.test()'— passed: 2,299 assertions plus three pre-existing broken cases;SupernodalLU internalspassed 72/72.git diff --check— passed.The remote branch was audited before the lease-protected rebase push; it contained only the prior bot-authored version of this same commit.