Import issquare from SciMLOperators in ForwardDiff extension - #1125
Merged
ChrisRackauckas merged 1 commit intoJul 29, 2026
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Jul 29, 2026
Member
Author
|
CI triage for the current run:
The scoped #1125 regressions remain locally green as recorded in the PR body. No test has been skipped, disabled, or loosened. |
ChrisRackauckas
marked this pull request as ready for review
July 29, 2026 21:27
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
issquaredirectly from its public owner,SciMLOperators, inLinearSolveForwardDiffExtRoot cause
LinearSolveForwardDiffExtcalled bareissquarewhile relying onusing SciMLBaseto make the name available indirectly. SciMLBase commitb9c3507a(Make strict QA owner-contract clean (#1472)) stopped reexporting SciMLOperators names. With SciMLBase 3.40.1, ForwardDiff initialization of a square linear problem therefore raised:SciMLOperators.issquareis exported, has a docstring, and is included in SciMLOperators' rendered interface documentation. The ChainRules extension already uses the same owner import.Investigation
fd8271c1with SciMLBase 3.40.1[0.16, 0.04]Verification
test/Core/forwarddiff_overloads.jlon SciMLBase 3.40.1: passNonlinearSolveAlg: 4/4GROUP=QA:git diff --check: passThe official Core run against SciMLBase 3.40.1 reached 629 passes, then stopped at the independent existing test use of bare
cache_operator. The samecache_operatorerror reproduces on unmodified LinearSolvefd8271c1; it is intentionally outside this focused PR and is being investigated separately. QA against SciMLBase 3.40.1 likewise reaches independent existing owner-contract failures for stalehas_concretizationand a qualifiedLinearSolve.SciMLOperatorsaccess. The registered 3.39.1 QA control is green as reported above.