Import cache_operator from SciMLOperators in Core tests - #1126
Merged
ChrisRackauckas merged 1 commit intoJul 29, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Commit Local verification plan/result:
All scoped checks completed as recorded in the PR body. The later |
Member
Author
|
Terminal CI audit: 53 checks passed; the five red checks are independent of this one-line
No unrelated changes will be added to #1126. |
ChrisRackauckas
marked this pull request as ready for review
July 29, 2026 21:30
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
cache_operatordirectly from its public owner,SciMLOperators, in the Core test that exercises cached inverse preconditionersRoot cause
test/Core/basictests.jlcalled barecache_operatorwhile relying on the transitive chainusing LinearSolve→ reexported SciMLBase names → SciMLOperators.SciMLBase commit
b9c3507a(Make strict QA owner-contract clean (#1472)) removed the blanket SciMLOperators reexport. The dependency boundary was checked directly:7b806c50(SciMLBase 3.40.0):cache_operatoris defined afterusing SciMLBaseb9c3507a: it is notGROUP=Corecontrol passesSciMLOperators.cache_operatoris exported/public, has a docstring, and is included in SciMLOperators' rendered interface documentation.Verification
Basic Testson SciMLBase 3.40.1, stacked only for validation with the independentissquarefix in Import issquare from SciMLOperators in ForwardDiff extension #1125: 635/635GROUP=Core: passedgit diff --check: passedThe full SciMLBase 3.40.1 Core stack continues past this fixed suite and then stops at a separate bare
FunctionOperatoruse intest/Core/default_algs.jl:167. QA on that dependency likewise exposes separate existing owner-contract failures: stalehas_concretizationinsrc/LinearSolve.jl:20and non-ownerLinearSolve.SciMLOperators.AbstractSciMLOperatoraccess inext/LinearSolveSparseArraysExt.jl:58. Those are intentionally outside this focused PR.