Skip to content

Spell out the SupernodalLU threshold test variable - #1128

Closed
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fix-supernodal-threshold-spelling
Closed

Spell out the SupernodalLU threshold test variable#1128
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fix-supernodal-threshold-spelling

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Ignore until reviewed by @ChrisRackauckas.

Summary

Root cause

A clean upstream/main checkout reproduced exactly two Typos 1.48.0 findings at test/Core/supernodal_lu.jl:176-177. An automated bisect identified 4c58ce272a79969d45eaa640bdf74c2a437263bf (#1119) as the first bad commit.

Verification

  • GROUP=Core JULIA_NUM_THREADS=2 julia +1.12 --project=. -e 'using Pkg; Pkg.test()' — passed (2,299 passes; three pre-existing broken cases; SupernodalLU internals 72/72)
  • typos-cli 1.48.0 . — passed with zero findings
  • julia +1.12 --project=<Runic env> -m Runic --check --diff test/Core/supernodal_lu.jl — passed
  • julia +1.12 --project=<Runic env> -m Runic --check --diff . — passed
  • git diff --check — passed

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Closing this as an exact duplicate of #1124. The current-main rebase and complete local Core/Typos/Runic evidence have been consolidated into #1124; this PR had no unique code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants