Spell out the SupernodalLU threshold test variable - #1128
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Spell out the SupernodalLU threshold test variable#1128ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
thrloop variable in the SupernodalLU Core test tothresholdRoot cause
A clean
upstream/maincheckout reproduced exactly two Typos 1.48.0 findings attest/Core/supernodal_lu.jl:176-177. An automated bisect identified4c58ce272a79969d45eaa640bdf74c2a437263bf(#1119) as the first bad commit.Verification
GROUP=Core JULIA_NUM_THREADS=2 julia +1.12 --project=. -e 'using Pkg; Pkg.test()'— passed (2,299 passes; three pre-existing broken cases;SupernodalLU internals72/72)typos-cli 1.48.0 .— passed with zero findingsjulia +1.12 --project=<Runic env> -m Runic --check --diff test/Core/supernodal_lu.jl— passedjulia +1.12 --project=<Runic env> -m Runic --check --diff .— passedgit diff --check— passed