Skip to content

Use SciMLOperators as the operator API owner - #1130

Draft
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fix-scimlbase340-owner-clean-imports
Draft

Use SciMLOperators as the operator API owner#1130
ChrisRackauckas-Claude wants to merge 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:agent/fix-scimlbase340-owner-clean-imports

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jul 30, 2026

Copy link
Copy Markdown
Member

Ignore until reviewed by @ChrisRackauckas.

Summary

  • remove the stale root has_concretization import
  • import AbstractSciMLOperator only through its owner, SciMLOperators
  • use the already imported owner type in LinearSolveSparseArraysExt
  • remove unused non-owner AbstractSciMLOperator imports from the CUDA and Metal extensions

Dependency boundary

SciMLBase commit b9c3507a (#1472) removed @reexport using SciMLOperators. A fresh current-main checkout with local SciMLBase 3.40.1 reproduced exactly two ExplicitImports errors: the stale has_concretization root import and LinearSolve.SciMLOperators.AbstractSciMLOperator accessed through a non-owner in the sparse extension.

SciMLOperators 1.25.1 is the declaring owner. Runtime checks confirm AbstractSciMLOperator is public and has_concretization is exported; both have docstrings and rendered docs/src/interface.md entries.

Verification

  • unchanged main, local SciMLBase 3.40.1: reproduced 18 passes, 2 ExplicitImports errors, and 2 existing broken cases
  • fixed GROUP=QA, local SciMLBase 3.40.1: passed (110 passes, 10 existing broken cases across QA/JET; allocation sets 48/48 and 8/8)
  • fixed GROUP=QA, registered-current SciMLBase 3.39.1: passed with the same counts
  • owner-clean GROUP=Core: 1,580 top-level assertions passed before the independent current-main FunctionOperator error owned by draft Import FunctionOperator from SciMLOperators in Core tests #1127; relevant sparse sets passed, including re-solve 133/133, SupernodalLU 72/72, sparse-vector RHS 12/12, and nonstructural zeros 141/141
  • official GPU environment: LinearSolveCUDAExt compiled and loaded successfully; no GPU runtime test was claimed on this host
  • Runic on all changed files and the full repository: passed
  • git diff --check: passed

Independent current-main prerequisites

No MKL/JET changes or QA suppressions are included.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>

Copy link
Copy Markdown
Member Author

One-hour terminal CI audit for exact head ac588f7beb: 55 checks succeeded, 4 were skipped, and 3 failed. All three are independent current-main failures; the owner-import patch itself has no hosted test failure.

Documentation and all branch-relevant QA, owner-clean import, platform-load, and formatting checks are green. No unrelated downstream workaround is being folded into this PR.

Copy link
Copy Markdown
Member Author

The downstream ModelingToolkit Julia 1.10 initialization failures have now been split precisely:

#4852 is a draft pending CI/review; this link is classification, not a claim that this PR's full matrix is green yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants