Use SciMLOperators as the operator API owner - #1130
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Use SciMLOperators as the operator API owner#1130ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
One-hour terminal CI audit for exact head
Documentation and all branch-relevant QA, owner-clean import, platform-load, and formatting checks are green. No unrelated downstream workaround is being folded into this PR. |
Member
Author
|
The downstream ModelingToolkit Julia 1.10 initialization failures have now been split precisely:
#4852 is a draft pending CI/review; this link is classification, not a claim that this PR's full matrix is green yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Summary
has_concretizationimportAbstractSciMLOperatoronly through its owner, SciMLOperatorsLinearSolveSparseArraysExtAbstractSciMLOperatorimports from the CUDA and Metal extensionsDependency boundary
SciMLBase commit
b9c3507a(#1472) removed@reexport using SciMLOperators. A fresh current-main checkout with local SciMLBase 3.40.1 reproduced exactly two ExplicitImports errors: the stalehas_concretizationroot import andLinearSolve.SciMLOperators.AbstractSciMLOperatoraccessed through a non-owner in the sparse extension.SciMLOperators 1.25.1 is the declaring owner. Runtime checks confirm
AbstractSciMLOperatoris public andhas_concretizationis exported; both have docstrings and rendereddocs/src/interface.mdentries.Verification
GROUP=QA, local SciMLBase 3.40.1: passed (110 passes, 10 existing broken cases across QA/JET; allocation sets 48/48 and 8/8)GROUP=QA, registered-current SciMLBase 3.39.1: passed with the same countsGROUP=Core: 1,580 top-level assertions passed before the independent current-mainFunctionOperatorerror owned by draft Import FunctionOperator from SciMLOperators in Core tests #1127; relevant sparse sets passed, including re-solve 133/133, SupernodalLU 72/72, sparse-vector RHS 12/12, and nonstructural zeros 141/141LinearSolveCUDAExtcompiled and loaded successfully; no GPU runtime test was claimed on this hostgit diff --check: passedIndependent current-main prerequisites
FunctionOperatorCore failure exposed by SciMLBase 3.40.1thrspell-check findings on current mainNo MKL/JET changes or QA suppressions are included.