use isfresh like mechinisim for precs#547
Merged
ChrisRackauckas merged 5 commits intoSciML:mainfrom Oct 19, 2024
Merged
Conversation
Contributor
|
I think we could keep the function SciMLBase.solve!(cache::LinearCache, args...; reuse_precs=cache.precsisfresh, kwargs...)
cache.precsisfresh=reuse_precs
solve!(cache, cache.alg, args...; kwargs...)
end |
Contributor
|
Or maybe this could go into function SciMLBase.reinit!(cache::LinearCache;
A = nothing,
b = cache.b,
u = cache.u,
p = nothing,
reinit_cache = false,
reuse_precs = false)
(; alg, cacheval, abstol, reltol, maxiters, verbose, assumptions, sensealg) = cache
isfresh = isnothing(A)
precsisfresh = ( isfresh || isnothing(p) ) && !reuse_precsAppears to me a bit more consistent, but not sure. |
Member
Author
|
good to merge? |
Contributor
|
oscardssmith#4 adds a test for for working reuse_precs |
Add test for "reuse_precs=true" + fix logic
Member
Author
|
thanks! |
Contributor
|
LGTM |
ChrisRackauckas
approved these changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #535, fixes #527 for real this time. I don't love this answer, but I think it is the easiest way for now.