Use SciMLTesting v1.0.0 (run_tests harness)#81
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Conversation
Replace the hand-written GROUP-dispatch in test/runtests.jl with a single SciMLTesting.run_tests(...) call. Behavior-equivalent refactor: same Core/QA group bodies, same group selection. Add SciMLTesting to the test deps and drop Pkg (now bundled by SciMLTesting; only used by the old harness). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Closing: this run_tests v1.0.0 conversion is NOT behavior-equivalent. This repo runs QA only for GROUP=="QA" and excludes it from "All" (the default local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hand-written
GROUP-dispatch intest/runtests.jlwith a singleSciMLTesting.run_tests(...)call (SciMLTesting v1.0.0).Shape
Single-package,
GROUP-dispatched, QA in an isolatedtest/qasub-env, defaultGROUP="Core".Mapping (behavior-equivalent)
core= thunk reproducing the originalCore||Allbody verbatim:include("interface_tests.jl"),include("jet_tests.jl"), and the inline@ode_def_bare/solveMATLAB-runtime checks. A thunk (not a file include) is required because that body runs in theruntests.jlscope whereusing DiffEqBase, MATLABDiffEq, ParameterizedFunctionsis in effect.QA=groups["QA"]with a declaredenv = test/qa. A declared-env group is not run under"All"and is selectable only viaGROUP="QA", exactly matching the original (if GROUP == "QA").activate_group_envreproduces the oldactivate_qa_env(activatetest/qa+Pkg.developthe repo root + instantiate). QA body kept verbatim (customJET.report_package+ report-count assertion), not collapsed intorun_qa.default = "Core"preserves the originalget(ENV, "GROUP", "Core").Routing verified for every CI-relevant
GROUP: unset→core, All→core, Core→core, QA→qa.Project.toml
[extras]/[targets].test/[compat]: addSciMLTesting(UUID09d9d899-...), dropPkg(only the old harness used it;Pkg.appears in no other test file; SciMLTesting bundles Pkg).Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code