Skip to content

Commit 1298c7b

Browse files
QA: strip redundant public-API EI ignores (SciMLTesting 1.7)
SciMLTesting 1.7 runs the two public-API ExplicitImports checks (check_all_qualified_accesses_are_public / check_all_explicit_imports_are_public) only on Julia >= 1.11, and the base-lib make-public releases (ModelingToolkit 11.29, Symbolics 7.28+, SymbolicUtils 4.36, SciMLBase 3.24) marked most of the previously-ignored names public. Verified against registered releases on Julia 1.12: of the 13 all_qualified_accesses_are_public ignores, only :topsort_equations (still non-public in ModelingToolkit) and :getname (re-exported by Symbolics from SymbolicIndexingInterface, non-public) remain flagged. The other 11 are now public and removed. QA group passes 17/17 on 1.12 and 15/15 on 1.10 (public checks skipped on the LTS). The all_qualified_accesses_via_owners list is a distinct (non public-API) check and is left untouched. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 79307cb commit 1298c7b

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

test/qa/qa.jl

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,9 @@ run_qa(
2727
all_qualified_accesses_are_public = (;
2828
ignore = (
2929
# not public in ModelingToolkit
30-
:get_eqs, :get_initial_conditions, :get_iv, :get_observed,
31-
:get_unknowns, :get_var_to_name, :topsort_equations,
32-
# not public in Symbolics
33-
:getname, :scalarize, :unwrap, :value,
34-
# not public in SymbolicUtils
35-
:isadd, :ismul,
30+
:topsort_equations,
31+
# not public in Symbolics (re-exported from SymbolicIndexingInterface)
32+
:getname,
3633
),
3734
),
3835
)

0 commit comments

Comments
 (0)