Skip to content

Commit 228f31d

Browse files
QA: migrate re-export-gap accesses to public owners + drop now-public ignores
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
1 parent 80d454a commit 228f31d

4 files changed

Lines changed: 4 additions & 3 deletions

File tree

Project.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
1111
RandomizedLinAlg = "0448d7d9-159c-5637-8537-fd72090fea46"
1212
Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
1313
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
14+
SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
1415
TSVD = "9449cd9e-2762-5aa3-a617-5413e99d722e"
1516

1617
[compat]
@@ -21,5 +22,6 @@ PrecompileTools = "1.2.1"
2122
RandomizedLinAlg = "0.1"
2223
Setfield = "1.1.2"
2324
SparseArrays = "1"
25+
SymbolicIndexingInterface = "0.3.49"
2426
TSVD = "0.4.4"
2527
julia = "1.10"

src/ModelOrderReduction.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ using DocStringExtensions: DocStringExtensions, FUNCTIONNAME, SIGNATURES, TYPEDS
55
using ModelingToolkit: ModelingToolkit, @variables, Differential, Equation, Num, ODESystem,
66
SymbolicUtils, Symbolics, arguments, build_function, complete,
77
expand, substitute, tearing_substitution
8+
using SymbolicIndexingInterface: SymbolicIndexingInterface
89
using LinearAlgebra: LinearAlgebra, /, \, mul!, qr, svd
910

1011
using Setfield: Setfield, @set!

src/deim.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ function deim(
143143
var_name = gensym(:ŷ)
144144
= (@variables $var_name(iv)[1:pod_dim])[1]
145145
@set! sys.unknowns = Symbolics.value.(Symbolics.scalarize(ŷ)) # new variables from POD
146-
ModelingToolkit.get_var_to_name(sys)[Symbolics.getname(ŷ)] = Symbolics.unwrap(ŷ)
146+
ModelingToolkit.get_var_to_name(sys)[SymbolicIndexingInterface.getname(ŷ)] = Symbolics.unwrap(ŷ)
147147

148148
deqs, eqs = get_deqs(sys) # split eqs into differential and non-differential equations
149149
rhs = [eq.rhs for eq in deqs]

test/qa/qa.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ run_qa(
2828
ignore = (
2929
# not public in ModelingToolkit
3030
:topsort_equations,
31-
# not public in Symbolics (re-exported from SymbolicIndexingInterface)
32-
:getname,
3331
),
3432
),
3533
)

0 commit comments

Comments
 (0)