Merge pull request #151 from ChrisRackauckas-Claude/fix-master-ci

Split JET tests into QA group; fix docs link + LaTeXStrings import

Author: ChrisRackauckas

.github/workflows/Tests.yml

@@ -28,10 +28,10 @@ jobs:
           - "pre"
         group:
           - Core
-          - nopre
+          - QA
         exclude:
           - version: "pre"
-            group: nopre
+            group: QA
     uses: "SciML/.github/.github/workflows/tests.yml@v1"
     with:
       julia-version: "${{ matrix.version }}"

docs/src/tutorials/deim_FitzHugh-Nagumo.md

@@ -37,11 +37,12 @@ steps:
  3. Project the model onto the identified subspace using DEIM to approximate nonlinear terms.
 
 For step 1, we first construct a
-[`ModelingToolkit.PDESystem`](https://mtk.sciml.ai/stable/systems/PDESystem/)
+[`ModelingToolkit.PDESystem`](https://docs.sciml.ai/ModelingToolkit/stable/API/PDESystem/)
 describing the original FitzHugh-Nagumo model.
 
 ```@example deim_FitzHugh_Nagumo
 using ModelingToolkit
+using LaTeXStrings
 @variables x t v(..) w(..)
 Dx = Differential(x)
 Dxx = Dx^2

test/deim.jl

@@ -38,8 +38,10 @@ order = 2
 discretization = MOLFiniteDifference(dxs, t; approx_order = order)
 ode_sys, tspan = symbolic_discretize(pde_sys, discretization)
 simp_sys = mtkcompile(ode_sys) # field substitutions is non-empty
-ode_prob = ODEProblem(simp_sys, nothing, tspan;
-    missing_guess_value = ModelingToolkit.MissingGuessValue.Constant(0.0))
+ode_prob = ODEProblem(
+    simp_sys, nothing, tspan;
+    missing_guess_value = ModelingToolkit.MissingGuessValue.Constant(0.0)
+)
 sol = solve(ode_prob, Tsit5(), saveat = 1.0)
 
 snapshot_simpsys = Array(sol.original_sol)

test/nopre/jet_tests.jl

@@ -0,0 +1,62 @@
+using Test, JET
+using ModelOrderReduction
+using LinearAlgebra: qr
+
+@testset "JET Static Analysis" begin
+    # Create test data
+    n = 20  # state dimension
+    m = 10  # number of snapshots
+    snapshot_matrix = Float64[sin(i * j / n) for i in 1:n, j in 1:m]
+    snapshot_vov = [Float64[sin(i * j / n) for i in 1:n] for j in 1:m]
+
+    # Create an orthonormal basis for deim_interpolation_indices
+    Q, _ = qr(snapshot_matrix)
+    deim_basis = Matrix(Q[:, 1:5])
+
+    # Restrict JET reports to issues originating in ModelOrderReduction itself.
+    # Without this, transitive symbolic-stack type piracy (e.g. SymbolicUtils
+    # overloading `ifelse`/`max` on `Integer`) bleeds into reports for purely
+    # numeric code that never touches symbolic types at runtime.
+    target = (ModelOrderReduction,)
+
+    @testset "deim_interpolation_indices type stability" begin
+        rep = JET.report_call(
+            ModelOrderReduction.deim_interpolation_indices,
+            (Matrix{Float64},); target_modules = target
+        )
+        @test length(JET.get_reports(rep)) == 0
+    end
+
+    @testset "matricize type stability" begin
+        rep = JET.report_call(
+            ModelOrderReduction.matricize,
+            (Vector{Vector{Float64}},); target_modules = target
+        )
+        @test length(JET.get_reports(rep)) == 0
+    end
+
+    @testset "POD constructor type stability" begin
+        # Matrix constructor
+        rep1 = JET.report_call(
+            ModelOrderReduction.POD,
+            (Matrix{Float64}, Int); target_modules = target
+        )
+        @test length(JET.get_reports(rep1)) == 0
+
+        # Vector{Vector} constructor
+        rep2 = JET.report_call(
+            ModelOrderReduction.POD,
+            (Vector{Vector{Float64}}, Int); target_modules = target
+        )
+        @test length(JET.get_reports(rep2)) == 0
+    end
+
+    @testset "reduce! with SVD type stability" begin
+        pod = POD(snapshot_matrix, 3)
+        rep = JET.report_call(
+            ModelOrderReduction.reduce!,
+            (typeof(pod), typeof(SVD())); target_modules = target
+        )
+        @test length(JET.get_reports(rep)) == 0
+    end
+end

test/nopre/Project.toml test/qa/Project.tomltest/nopre/Project.toml renamed to test/qa/Project.toml

@@ -14,19 +14,19 @@ if GROUP == "All" || GROUP == "Core"
     end
 end
 
-if GROUP == "nopre"
+if GROUP == "All" || GROUP == "QA"
     using Pkg
-    Pkg.activate(@__DIR__() * "/nopre")
+    Pkg.activate(@__DIR__() * "/qa")
     Pkg.develop(path = dirname(@__DIR__))
     Pkg.instantiate()
 
     @safetestset "Quality Assurance" begin
-        include("nopre/qa_tests.jl")
+        include("qa/qa_tests.jl")
     end
     @safetestset "Explicit Imports" begin
-        include("nopre/explicit_imports_tests.jl")
+        include("qa/explicit_imports_tests.jl")
     end
     @safetestset "JET Static Analysis" begin
-        include("nopre/jet_tests.jl")
+        include("qa/jet_tests.jl")
     end
 end