Skip to content

Commit ab48809

Browse files
QA: run_qa v1.6 form + ExplicitImports
Replace the hand-rolled Aqua + ExplicitImports QA files (qa_tests.jl, explicit_imports_tests.jl) with a single qa.jl on the SciMLTesting 1.6 `run_qa` form, with ExplicitImports enabled (all six checks). - Aqua: `run_qa` runs the full `Aqua.test_all` (11 checks); no broken markers or aqua_kwargs tweaks needed — all pass. - ExplicitImports: `explicit_imports = true`. Two checks needed ignore lists for third-party symbolic-stack internal names re-exported but not owned/public by ModelingToolkit/Symbolics (documented per source pkg); the other four checks pass unmodified. - JET: `jet = false` in run_qa. Whole-package JET hits a toplevel `invalid redefinition of constant ModelOrderReduction.TSVD` (the exported `TSVD` struct collides with the `TSVD` dependency package under JET's toplevel virtualizer). The existing targeted `report_call` checks in jet_tests.jl provide the JET coverage and stay as a separate group file. test/qa/Project.toml: drop ExplicitImports (transitive via SciMLTesting), keep Aqua (ambiguities child-proc needs it direct) and JET (jet_tests.jl), bump SciMLTesting compat to "1.6". Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 68c4861 commit ab48809

4 files changed

Lines changed: 40 additions & 30 deletions

File tree

test/qa/Project.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
[deps]
22
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
3-
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
43
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
54
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
65
ModelOrderReduction = "207801d6-6cee-43a9-ad0c-f0c64933efa0"
@@ -10,11 +9,10 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
109

1110
[compat]
1211
Aqua = "0.8"
13-
ExplicitImports = "1"
1412
JET = "0.9, 0.10, 0.11"
1513
LinearAlgebra = "1"
1614
SafeTestsets = "0.0.1, 0.1"
17-
SciMLTesting = "1"
15+
SciMLTesting = "1.6"
1816
Test = "1"
1917

2018
[sources]

test/qa/explicit_imports_tests.jl

Lines changed: 0 additions & 13 deletions
This file was deleted.

test/qa/qa.jl

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
using SciMLTesting, ModelOrderReduction, Test
2+
3+
run_qa(
4+
ModelOrderReduction;
5+
explicit_imports = true,
6+
# Whole-package JET (`report_package`/`test_package`) hits a toplevel
7+
# `invalid redefinition of constant ModelOrderReduction.TSVD` error: the package
8+
# exports a `TSVD` struct whose name collides with the `TSVD` dependency package
9+
# under JET's toplevel virtualizer. JET coverage is provided by the targeted
10+
# `report_call` checks in jet_tests.jl, which sidestep the toplevel re-eval.
11+
jet = false,
12+
ei_kwargs = (;
13+
# Internal symbolic-stack names that ModelingToolkit/Symbolics re-export but
14+
# neither own nor mark public. `via_owners` flags the re-export; `are_public`
15+
# flags the non-public status. ModelOrderReduction uses them as internal API.
16+
all_qualified_accesses_via_owners = (;
17+
ignore = (
18+
# owner ModelingToolkitBase, accessed via ModelingToolkit
19+
:get_eqs, :get_initial_conditions, :get_iv, :get_observed,
20+
:get_unknowns, :get_var_to_name, :topsort_equations,
21+
# owner SymbolicUtils, accessed via Symbolics
22+
:scalarize, :unwrap,
23+
# owner SymbolicIndexingInterface, accessed via Symbolics
24+
:getname,
25+
),
26+
),
27+
all_qualified_accesses_are_public = (;
28+
ignore = (
29+
# not public in ModelingToolkit
30+
:get_eqs, :get_initial_conditions, :get_iv, :get_observed,
31+
:get_unknowns, :get_var_to_name, :topsort_equations,
32+
# not public in Symbolics
33+
:getname, :scalarize, :unwrap, :rhss, :value,
34+
# not public in SymbolicUtils
35+
:isadd, :ismul,
36+
),
37+
),
38+
)
39+
)

test/qa/qa_tests.jl

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)