Commit ab48809
QA: run_qa v1.6 form + ExplicitImports
Replace the hand-rolled Aqua + ExplicitImports QA files (qa_tests.jl,
explicit_imports_tests.jl) with a single qa.jl on the SciMLTesting 1.6
`run_qa` form, with ExplicitImports enabled (all six checks).
- Aqua: `run_qa` runs the full `Aqua.test_all` (11 checks); no broken
markers or aqua_kwargs tweaks needed — all pass.
- ExplicitImports: `explicit_imports = true`. Two checks needed ignore
lists for third-party symbolic-stack internal names re-exported but not
owned/public by ModelingToolkit/Symbolics (documented per source pkg);
the other four checks pass unmodified.
- JET: `jet = false` in run_qa. Whole-package JET hits a toplevel
`invalid redefinition of constant ModelOrderReduction.TSVD` (the exported
`TSVD` struct collides with the `TSVD` dependency package under JET's
toplevel virtualizer). The existing targeted `report_call` checks in
jet_tests.jl provide the JET coverage and stay as a separate group file.
test/qa/Project.toml: drop ExplicitImports (transitive via SciMLTesting),
keep Aqua (ambiguities child-proc needs it direct) and JET (jet_tests.jl),
bump SciMLTesting compat to "1.6".
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 68c4861 commit ab48809
4 files changed
Lines changed: 40 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
| |||
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | | - | |
14 | 12 | | |
15 | 13 | | |
16 | 14 | | |
17 | | - | |
| 15 | + | |
18 | 16 | | |
19 | 17 | | |
20 | 18 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
This file was deleted.
0 commit comments