Improve explicit imports hygiene#135
Merged
ChrisRackauckas merged 1 commit intoJan 3, 2026
Merged
Conversation
- Replace `using Package` with selective `using Package: name1, name2` imports to eliminate all implicit imports - Add ExplicitImports.jl tests to CI to ensure import hygiene is maintained - Updated imports in: - src/ModelOrderReduction.jl: Added explicit imports for DocStringExtensions, ModelingToolkit, LinearAlgebra, and Setfield - src/utils.jl: Added explicit import for SparseArrays.sparse - src/precompile.jl: Added explicit imports for PrecompileTools macros - Added test/explicit_imports.jl with tests for no implicit or stale imports - Added ExplicitImports to test dependencies in test/Project.toml All tests pass. The package now follows best practices for explicit imports, reducing the risk of breakage from transitive dependency changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 similar comment
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
using Package: name1, name2syntaxChanges Made
Source Files Updated
SparseArrays.sparseTest Infrastructure
Before
After
Benefits
cc @ChrisRackauckas
🤖 Generated with Claude Code