Improve explicit imports hygiene

src/ModelOrderReduction.jl

@@ -1,11 +1,13 @@
 module ModelOrderReduction
 
-using DocStringExtensions
+using DocStringExtensions: DocStringExtensions, FUNCTIONNAME, SIGNATURES, TYPEDSIGNATURES
 
-using ModelingToolkit
-using LinearAlgebra
+using ModelingToolkit: ModelingToolkit, @variables, Differential, Equation, Num, ODESystem,
+                       SymbolicUtils, Symbolics, arguments, build_function, complete,
+                       expand, substitute, tearing_substitution
+using LinearAlgebra: LinearAlgebra, /, \, mul!, qr, svd
 
-using Setfield
+using Setfield: Setfield, @set!
 
 include("utils.jl")
 

src/precompile.jl

@@ -1,4 +1,4 @@
-using PrecompileTools
+using PrecompileTools: PrecompileTools, @compile_workload, @setup_workload
 
 @setup_workload begin
     # Setup code - create minimal test data

src/utils.jl

@@ -1,4 +1,4 @@
-using SparseArrays
+using SparseArrays: SparseArrays, sparse
 using ModelingToolkit: iscall, operation
 
 """

test/Project.toml

@@ -1,14 +1,16 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
-OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
+ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
 MethodOfLines = "94925ecb-adb7-4558-8ed8-f975c56a0bf4"
 ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
+OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
 Aqua = "0.8"
-OrdinaryDiffEq = "6"
+ExplicitImports = "1"
 MethodOfLines = "0.11"
 ModelingToolkit = "10.10"
+OrdinaryDiffEq = "6"
 SafeTestsets = "0.1"

test/explicit_imports.jl

@@ -0,0 +1,13 @@
+using Test
+using ExplicitImports
+using ModelOrderReduction
+
+@testset "ExplicitImports" begin
+    @testset "No implicit imports" begin
+        @test check_no_implicit_imports(ModelOrderReduction) === nothing
+    end
+
+    @testset "No stale explicit imports" begin
+        @test check_no_stale_explicit_imports(ModelOrderReduction) === nothing
+    end
+end

test/runtests.jl

@@ -3,6 +3,9 @@ using SafeTestsets
 @safetestset "Quality Assurance" begin
     include("qa.jl")
 end
+@safetestset "Explicit Imports" begin
+    include("explicit_imports.jl")
+end
 @safetestset "POD" begin
     include("DataReduction.jl")
 end