Use SciMLTesting v1.2 (folder-based run_tests)#158
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
June 14, 2026 12:59
efe2dfc to
9f24727
Compare
ChrisRackauckas
marked this pull request as ready for review
June 14, 2026 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2 folder-discovery model: the whole file becomesrun_tests()readstest/test_groups.toml(unchanged) and discovers each group's files from the folder layout, running every file in its own isolated@safetestset. This is behavior-equivalent to the old hand-writtenGROUPdispatch.Folder mapping (behavior-preserving)
GROUP == "Core", and the Core portion of"All"): the top-leveltest/*.jlfiles —DataReduction.jl,deim.jl,utils.jl— exactly the three files the oldGROUP == "All" || "Core"block ran (asPOD/utils/DEIM). They stay at the top level (no move) and run in the main test env.GROUP == "QA"): the existingtest/qa/folder —qa_tests.jl,explicit_imports_tests.jl,jet_tests.jl— the same three files the oldGROUP == "All" || "QA"block ran. The folder carries its owntest/qa/Project.toml, so the harnessactivate_group_env(test/qa)doesPkg.activate+Pkg.develop(repo root)+Pkg.instantiate(), equivalent to the old manualPkg.activate/Pkg.develop/Pkg.instantiate.test/test_groups.tomlis unchanged ([Core],[QA]); the CI matrix runs Core and QA as separate lanes, matching the harness mapping.Project.toml
test/Project.toml: addSciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"(+[compat] SciMLTesting = "1"); dropPkg(deps + compat) — only the old harness used it (notest/*.jlreferencesPkg.; the v1.2 harness owns allPkgoperations).SafeTestsetsandTestretained.test/qa/Project.toml: addSciMLTesting(+compat"1"),SafeTestsets(+compat"0.0.1, 0.1"),Test(+compat"1") so the folder-discovered files run under@safetestsetin the QA sub-env. Added a relative[sources] ModelOrderReduction = {path = "../.."}(belt-and-suspenders for Julia 1.11+;activate_group_envalso develops the package).Verification
TOML.parsefileon everyProject.toml+test_groups.toml; asserted SciMLTesting UUID/compat present,Pkgremoved from test deps,test_groups.tomlkeys unchanged.Meta.parseallonruntests.jland every test file: no parse errors.Core→{DataReduction, deim, utils},QA→{qa_tests, explicit_imports_tests, jet_tests}with sub-env activation,All→ Core (QA excluded by design, run as its own CI lane). Matches the old dispatcher.Heavy suite not run locally; per-PR CI validates.
Ignore until reviewed by @ChrisRackauckas.