Merge pull request #4690 from KristofferC/kc/reorder_parameters_default

use the cached `reorder_parameters` in a few more places

Author: AayushSabharwal

lib/ModelingToolkitBase/src/systems/codegen.jl

@@ -41,11 +41,10 @@ function generate_rhs(
         kwargs...
     )
     dvs = unknowns(sys)
-    ps = parameters(sys; initial_parameters = true)
     eqs = equations(sys)
     obs = observed(sys)
     u = dvs
-    p = reorder_parameters(sys, ps)
+    p = reorder_parameters(sys) # 1 arg to use the cached version
     if cachesyms isa Vector{Vector{SymbolicT}}
         append!(p, cachesyms)
     end

src/problems/sccnonlinearproblem.jl

@@ -15,8 +15,7 @@ function CacheWriter(
         exprs::SCCCacheVarsExprsElT, solsyms;
         eval_expression = false, eval_module = @__MODULE__, cse = true, sparse = false
     )
-    ps = parameters(sys; initial_parameters = true)
-    rps = reorder_parameters(sys, ps)
+    rps = reorder_parameters(sys)  # 1 arg to use the cached version
     cache_writes = SymbolicT[]
     for (i, T) in enumerate(buffer_types)
         regions = SU.RegionsT()