Skip to content

Commit 0f23eaf

Browse files
committed
test(bvp): remove direct EvalSol comparison
The discrepancy between the interpolation methods is fixed by SciML/BoundaryValueDiffEq.jl#452
1 parent 7691a29 commit 0f23eaf

1 file changed

Lines changed: 5 additions & 12 deletions

File tree

lib/ModelingToolkitBase/test/bvproblem.jl

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -149,24 +149,17 @@ end
149149
end
150150

151151
function test_solvers(
152-
solvers, prob, u0map, constraints, equations = []; dt = 0.005, atol = 1.0e-2
152+
solvers, prob, u0map, constraints, equations = []; dt = 0.005, atol = 5.0e-6
153153
)
154154
for solver in solvers
155155
println("Solver: $solver")
156-
sol = solve(prob, solver(), dt = dt, abstol = 1.0e-8, reltol = 1.0e-8)
156+
sol = solve(prob, solver(), dt = dt)
157157
@test SciMLBase.successful_retcode(sol.retcode)
158158
p = prob.p
159159
t = sol.t
160160
bc = prob.f.bc
161161
ns = length(prob.u0)
162162

163-
cache = init(prob, solver(), dt = dt, abstol = 1.0e-8, reltol = 1.0e-8)
164-
eval_sol = BoundaryValueDiffEqMIRK.EvalSol(
165-
BoundaryValueDiffEqMIRK.__restructure_sol(
166-
sol.u, cache.in_size
167-
), cache.mesh, cache
168-
)
169-
@test bc(zeros(ns), eval_sol, p, t) zeros(ns)
170163
if isinplace(prob.f)
171164
resid = zeros(ns)
172165
bc(resid, sol, p, t)
@@ -211,22 +204,22 @@ end
211204
bvp = SciMLBase.BVProblem{true, SciMLBase.AutoSpecialize}(
212205
lksys, u0map, tspan; guesses = guess, cse = false
213206
)
214-
test_solvers(solvers, bvp, u0map, constr; dt = 1.0e-4)
207+
test_solvers(solvers, bvp, u0map, constr; dt = 1.0e-2)
215208

216209
# Testing that more complicated constraints give correct solutions.
217210
constr = [EvalAt(0.2)(y) + EvalAt(0.8)(x) ~ 3.0, EvalAt(0.3)(y) ~ 2.0]
218211
@mtkcompile lksys = System(eqs, t; constraints = constr)
219212
bvp = SciMLBase.BVProblem{false, SciMLBase.FullSpecialize}(
220213
lksys, u0map, tspan; guesses = guess
221214
)
222-
test_solvers(solvers, bvp, u0map, constr; dt = 1.0e-4)
215+
test_solvers(solvers, bvp, u0map, constr; dt = 1.0e-2)
223216

224217
constr =* β - EvalAt(0.6)(x) ~ 0.0, EvalAt(0.2)(y) ~ 3.0]
225218
@mtkcompile lksys = System(eqs, t; constraints = constr)
226219
bvp = SciMLBase.BVProblem{true, SciMLBase.AutoSpecialize}(
227220
lksys, u0map, tspan; guesses = guess
228221
)
229-
test_solvers(solvers, bvp, u0map, constr; dt = 1.0e-4)
222+
test_solvers(solvers, bvp, u0map, constr; dt = 1.0e-2)
230223
end
231224

232225
# Cartesian pendulum from the docs.

0 commit comments

Comments
 (0)