Skip to content

Commit 3a866b1

Browse files
Raise ModelingToolkitBase OffsetArrays floor
ModelingToolkitBase uses the callable Origin behavior introduced in OffsetArrays 1.11 when indexing array-parameter slices. Align the compatibility floor and assert the slice index directly in the index-cache tests. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
1 parent d17df95 commit 3a866b1

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

lib/ModelingToolkitBase/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ Moshi = "0.3.6"
145145
NaNMath = "0.3, 1"
146146
NonlinearSolve = "4.19"
147147
NonlinearSolveBase = "2.31"
148-
OffsetArrays = "1.3.0"
148+
OffsetArrays = "1.11"
149149
OptimizationBase = "5"
150150
OptimizationIpopt = "1"
151151
OptimizationOptimJL = "0.4"

lib/ModelingToolkitBase/test/index_cache.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ end
8787
@test_throws ArgumentError reorder_dimension_by_tunables!(dst, sys, src, [p, q, r])
8888
@test_throws ArgumentError reorder_dimension_by_tunables(sys, src, [p, q, r])
8989
sys = complete(sys)
90+
@test parameter_index(sys, r[:, 1]).idx == [5, 6]
9091
# and the arrays must have matching size
9192
@test_throws ArgumentError reorder_dimension_by_tunables!(
9293
zeros(2, 4), sys, src, [p, q, r]

0 commit comments

Comments
 (0)