Merge pull request #4659 from SciML/as/reversible-tfs-2

refactor: update MTK to reversible transformations API

Author: AayushSabharwal

Project.toml

@@ -85,9 +85,9 @@ Libdl = "1"
 LinearAlgebra = "1"
 LinearSolve = "3.66"
 Logging = "1"
-ModelingToolkitBase = "1.44"
+ModelingToolkitBase = "1.46"
 ModelingToolkitStandardLibrary = "2.20"
-ModelingToolkitTearing = "1.12.1"
+ModelingToolkitTearing = "1.16"
 Moshi = "0.3.6"
 NonlinearSolve = "4.3"
 OffsetArrays = "1.3.0"

lib/ModelingToolkitBase/test/dde.jl

@@ -1,4 +1,5 @@
 using ModelingToolkitBase, DelayDiffEq, OrdinaryDiffEq, StaticArrays, Test
+import DiffEqNoiseProcess
 using SymbolicIndexingInterface: is_markovian
 using ModelingToolkitBase: t_nounits as t, D_nounits as D
 using Setfield: @set!

src/problems/sccnonlinearproblem.jl

@@ -708,7 +708,7 @@ function calculate_op_from_u0_p(sys::System, u0::Union{Nothing, AbstractVector},
         end
     end
 
-    _ss = unhack_system(sys)
+    _ss = MTKBase.reverse_all_default_reversible_transformations(sys)
     for eq in observed(_ss)
         write_possibly_indexed_array!(op, eq.lhs, eq.rhs, COMMON_NOTHING)
     end

test/structural_transformation/tearing.jl

@@ -279,10 +279,11 @@ end
     @test length(equations(sys3)) == 1
     @test isequal(only(unknowns(sys3)), sys3.capacitor.v)
 
-    idx = findfirst(isequal(sys3.resistor1.v), observables(sys3))
-    rhs = observed(sys3)[idx].rhs
-    @test operation(rhs) === getindex
-    @test operation(arguments(rhs)[1]) === (\)
+    idx = findfirst(observed(sys3)) do eq
+        arr, isarr = ModelingToolkit.MTKBase.split_indexed_var(eq.rhs)
+        isarr && iscall(arr) && operation(arr) === (\)
+    end
+    @test idx !== nothing
 
     prob1 = ODEProblem(sys1, [], (0.0, 10.0); guesses = [sys1.resistor1.v => 1.0])
     prob2 = ODEProblem(sys2, [], (0.0, 10.0))